NameSilo

Strange PHP error.

Spaceship Spaceship
Watch
Barrucadu

Barrucadu

Established Member
โ˜… 20 โ˜…
Impact
64
PHP: 
<?php
 // Where the file is going to be placed temporarly
$target_path = "/";

$target_path = $target_path . basename( $_FILES['uploadedfile']['name']);

$_FILES['uploadedfile']['tmp_name']; // temp file

$target_path = "/uploads/";
$oldfile =  basename($_FILES['uploadedfile']['name']);

// getting the extention
$pos = strpos($oldfile,".",0);
$ext = trim(substr($oldfile,$pos+1,strlen($oldfile))," ");

if(!$ext = "gif") {
	if(!$ext = "jpg") {
		if(!$ext = "png") {
			if(!$ext = "bmp") {
				echo "Dissallowed File Extension!";
				echo "<p>Allowed extensions are .gif, .jpg, .png and .bmp</p>";
				echo "<p><a href=\"Home.php\">Try Again</a></p>";
				die();
			}
		}
	}
}

//Check the size
if(!filesize($_FILES['uploadedfile']['name']) <= 1048576){
    echo "File too large!";
    echo "<p>Maximum size is 1MB</p>";
    die();
}
//new file name exmaple for a profile image of a user
$newfile = Date("d:S:w:z:W:B:s:i") . "." . $ext;

// move the file to the final destination
$target_path = $target_path . basename($newfile);

if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)) {
     echo "The file ". basename( $_FILES['uploadedfile']['name']). " has been uploaded";
	 echo "<p>The URL is <b>http://www.ISC.tk/uploads/". $newfile . "</b></p>";
	 echo "<p>To view your file visit <b>http://www.ISC.tk/uploads/browseupload.php?file=". $newfile . "</b></p>";
	 echo "<p>We reserve the right to delete any file on our server.</p>"; 
	 echo "<p><a href=\"Home.php\">Upload Another</a></p>";
} else{
     echo "There was an error uploading the file, please try again!";
	 echo "<p><a href=\"Home.php\">Try Again</a></p>";
}
?>

EDIT: I just checked again and the whole page dosnt work so I edited it in.
 
Reply
0
0 Like
0 Thanks
•••
The views expressed on this page by users and staff are their own, not those of NamePros.
AfternicAfternic
Sort by date Sort by points
...what's your error?
 
Reply
0
0 Like
0 Thanks
•••
sorry, should have metioned that.

1) it says all files i try to upload are over 1MB even when they're not.
2) it says the file upload failed if i disable the size checker.

i havent found any more errors yet.

incase you need it heres the HTML of the form on Home.php thats sending the file:

Code: 
<form action="upload.php" method="post" enctype="multipart/form-data" name="form1">
    <table width="414" border="0">
      <tr>
        <td width="158">File Location: </td>
        <td width="246"><input name="file" type="file" id="file"></td>
      </tr>
    </table>
    <p>* The file cannot exceed 1 mb.<br>
      ** Allowed file extensions are .gif, .jpg, .png and .bmp      <br>
    </p>
    <p>
      <input type="submit" name="Submit" value="Upload File">
</p>
  </form>
 
Last edited:
Reply
0
0 Like
0 Thanks
•••
Okay, so really what you want to do is fix the first error which will also fix the second one.

Got it - you have <= in the size checker. You want >= ;)

*lol* right now it won't let files UNDER 1 MB in :D Yeah, change that :)
 
Reply
0
0 Like
0 Thanks
•••
1) ok, i tried what you said and it didnt work.
2) the size checker IF statement is
PHP: 
if(!filesize($_FILES['uploadedfile']['name']) <= 1048576){
so if it was >= it would be "if filesize is not greater-than or equal to 1MB disallow it". (! does mean not dosnt it?)
 
Reply
0
0 Like
0 Thanks
•••
Its because the code you have is comparing the file name and not the file size

try this:

PHP: 
//Check the size
if(!filesize($_FILES['uploadedfile']['size']) <= 1048576){
    echo "File too large!";
    echo "<p>Maximum size is 1MB</p>";
    die();
}
 
Reply
0
0 Like
0 Thanks
•••
ahhhh, i knew it would be some stupid mistake (like all my mistakes in php)

ok, I messed arround with the syntax and I got
PHP: 
if(filesize($_FILES['uploadedfile']['size']) >= 1048576){
    echo "File too large!";
    echo "<p>Maximum size is 1MB</p>";
    die();
}

which now works. but it still says there was an error uploading this file, also can someone tell me if me if the extension checker (in my first post, but i'll repost it now) would work?
PHP: 
// getting the extention
$pos = strpos($oldfile,".",0);
$ext = trim(substr($oldfile,$pos+1,strlen($oldfile))," "); 
if(!$ext = "gif") {
	if(!$ext = "jpg") {
		if(!$ext = "png") {
			if(!$ext = "bmp") {
				echo "Dissallowed File Extension!";
				echo "<p>Allowed extensions are .gif, .jpg, .png and .bmp</p>";
				echo "<p><a href=\"Home.php\">Try Again</a></p>";
				die();
			}
		}
	}
}

ATM whats its supposed to do is check if its not a gif, jpg, png or bmp it shows the error message. Im new to PHP so i just guessed at the code, hopefully I got it right.
 
Last edited:
Reply
0
0 Like
0 Thanks
•••
actaully i just realised my code is wrong it should be


PHP: 
//Check the size
if($_FILES['uploadedfile']['size'] >= 1048576){
    echo "File too large!";
    echo "<p>Maximum size is 1MB</p>";
    die();
}

have you check that you have permission to write to the upload directory
 
Last edited:
Reply
0
0 Like
0 Thanks
•••
That's still checking to see if it's SMALLER than 1 MB.

You need to reverse the <= to be >=.
 
Reply
0
0 Like
0 Thanks
•••
Amnezia said:
have you check that you have permission to write to the upload directory
Click to expand...


should have, its on my pc.
 
Reply
0
0 Like
0 Thanks
•••
heres how i would test for the correct extension

PHP: 
$ext = strrchr($_FILES['uploadedfile']['name'], '.');

if((!$ext=="gif")&&(!$ext=="jpg")&&(!$ext=="png")&&(!$ext=="bmp")){

   echo "Dissallowed File Extension!";
   echo "<p>Allowed extensions are .gif, .jpg, .png and .bmp</p>";
   echo "<p><a href=\"Home.php\">Try Again</a></p>";
   die();

}
 
Reply
0
0 Like
0 Thanks
•••
Amnezia said:
heres how i would test for the correct extension

PHP: 
$ext = strrchr($_FILES['uploadedfile']['name'], '.');

if((!$ext=="gif")&&(!$ext=="jpg")&&(!$ext=="png")&&(!$ext=="bmp")){

   echo "Dissallowed File Extension!";
   echo "<p>Allowed extensions are .gif, .jpg, .png and .bmp</p>";
   echo "<p><a href=\"Home.php\">Try Again</a></p>";
   die();

}
Click to expand...

hmmm... when i run it it seams to skip the extension checking... it just says "File Upload Failed"
 
Reply
0
0 Like
0 Thanks
•••
Just check the MIME type... it's more secure ;)
 
Reply
0
0 Like
0 Thanks
•••
PHP: 
if(!$ext = "gif") {
    if(!$ext = "jpg") {
        if(!$ext = "png") {
            if(!$ext = "bmp") {
                echo "Dissallowed File Extension!";
                echo "<p>Allowed extensions are .gif, .jpg, .png and .bmp</p>";
                echo "<p><a href=\"Home.php\">Try Again</a></p>";
                die();
            }
        }
    }
}

That is abit to much eh? I would suggest using something like..
PHP: 
$FILE_EXTS  = array('.zip','.jpg','.png','.gif','.bmp'); 
$FILE_MIMES = array('image/jpeg','image/jpg','image/gif'
                   ,'image/png','application/msword');

$file_type = $_FILES['userfile']['type']; 
$file_name = $_FILES['userfile']['name'];
$file_ext = strtolower(substr($file_name,strrpos($file_name,".")));

if(!in_array($file_type, $FILE_MIMES) 
          && !in_array($file_ext, $FILE_EXTS)) {
   Die( "Disallowed file type.");
}

The above basically sets an array which allows certain ext& MIME types in_array(); function basically checks to see if the file ext/MIME is there. In this case if it isn't there it reports an error (which is !'s fault)

Regards,
 
Reply
0
0 Like
0 Thanks
•••
ok
PHP: 
// checking the extention
$FILE_EXTS  = array('.jpg','.png','.gif','.bmp','.jpx','.jpe', '.GIF','.JPG','.JPX','.JPE','.PNG','.BMP');
$file_name = $_FILES['userfile']['name'];
$file_ext = strtolower(substr($file_name,strrpos($file_name,".")));

if(!in_array($file_ext, $FILE_EXTS)) {
   Die( "Disallowed file extension.");
}
dosnt work, now i'll try
PHP: 
 $FILE_EXTS  = array('.zip','.jpg','.png','.gif','.bmp');
$FILE_MIMES = array('image/jpeg','image/jpg','image/gif'
                   ,'image/png','application/msword');

$file_type = $_FILES['userfile']['type'];
$file_name = $_FILES['userfile']['name'];
$file_ext = strtolower(substr($file_name,strrpos($file_name,".")));

if(!in_array($file_type, $FILE_MIMES)
          && !in_array($file_ext, $FILE_EXTS)) {
   Die( "Disallowed file type.");
}


EDIT:

ok, neither work, is it something wrong with my form?
Code: 
<form action="upload.php" method="post" enctype="multipart/form-data" name="form1">
    <table width="414" border="0">
      <tr>
        <td width="158">File Location: </td>
        <td width="246"><input name="file" type="file" id="file"></td>
      </tr>
    </table>
    <p>* The file cannot exceed 1 mb.<br>
      ** Allowed file extensions are .gif, .jpg, .png and .bmp      <br>
    </p>
    <p>
      <input type="submit" name="Submit" value="Upload File">
</p>
  </form>
 
Reply
0
0 Like
0 Thanks
•••
I think it could be because your trying to create a file with a : in the name
 
Reply
0
0 Like
0 Thanks
•••
wheres that?
 
Reply
0
0 Like
0 Thanks
•••
Possible - : is an invalid character in filenames.

When you go to rename the file to the date...
 
Reply
0
0 Like
0 Thanks
•••
ok, i messed around with it (file extension still not working, so its disabled for now) heres teh current code

PHP: 
<?php
 // Where the file is going to be placed temporarly
$target_path = "/";

$target_path = $target_path . basename( $_FILES['uploadedfile']['name']);

$_FILES['uploadedfile']['tmp_name']; // temp file

$target_path = "/uploads/";
$oldfile =  basename($_FILES['uploadedfile']['name']);

/*// checking the extention
$FILE_EXTS  = array('.jpg','.png','.gif','.bmp','.jpx','.jpe', '.GIF','.JPG','.JPX','.JPE','.PNG','.BMP');
$file_name = $_FILES['userfile']['name'];
$file_ext = strtolower(substr($file_name,strrpos($file_name,".")));

if(!in_array($file_ext, $FILE_EXTS)) {
   Die( "Disallowed file extension.");
}*/

//Check the size
if(filesize($_FILES['uploadedfile']['size']) >= 1048576){
    die( "File too large!");
}
//new file name exmaple for a profile image of a user
$newfile = Rand(1,9999999999) . $ext;

// move the file to the final destination
$target_path = $target_path . basename($newfile);

if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)) {
     echo "The file ". basename( $_FILES['uploadedfile']['name']). " has been uploaded";
	 echo "<p>The URL is <b>http://www.ISC.tk/uploads/". $newfile . "</b></p>";
	 echo "<p>To view your file visit <b>http://www.ISC.tk/uploads/browseupload.php?file=". $newfile . "</b></p>";
	 echo "<p>We reserve the right to delete any file on our server.</p>"; 
	 die( "<p><a href=\"Home.php\">Upload Another</a></p>");
} else{
     echo "There was an error uploading the file, please try again!";
	 die( "<p><a href=\"Home.php\">Try Again</a></p>");
}
?>

and it still dosnt work.
 
Last edited:
Reply
0
0 Like
0 Thanks
•••
ok this will work to check the extension

PHP: 
 $ext = strrchr($_FILES['uploadedfile']['name'], '.');

if((!$ext==".gif")&&(!$ext==".jpg")&&(!$ext==".png")&&(!$ext==".bmp")){

   echo "Dissallowed File Extension!";
   echo "<p>Allowed extensions are .gif, .jpg, .png and .bmp</p>";
   echo "<p><a href=\"Home.php\">Try Again</a></p>";
   die();

}

i missed the dots in the if statement

full code

PHP: 
<?php
// Where the file is going to be placed temporarly
$target_path = "/";

$target_path = $target_path . basename( $_FILES['uploadedfile']['name']);

$_FILES['uploadedfile']['tmp_name']; // temp file

$target_path = "/uploads/";

$oldfile =  basename($_FILES['uploadedfile']['name']);
 
$ext = strrchr($_FILES['uploadedfile']['name'], '.');

if((!$ext==".gif")&&(!$ext==".jpg")&&(!$ext==".png")&&(!$ext==".bmp")){

   echo "Dissallowed File Extension!";
   echo "<p>Allowed extensions are .gif, .jpg, .png and .bmp</p>";
   echo "<p><a href=\"Home.php\">Try Again</a></p>";
   die();

} 
//Check the size
if($_FILES['uploadedfile']['size']) >= 1048576){
    die( "File too large!");
}
//new file name exmaple for a profile image of a user
$newfile = Rand(1,9999999999) . $ext;

// move the file to the final destination
$target_path = $target_path . basename($newfile);

if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)) {
     echo "The file ". basename( $_FILES['uploadedfile']['name']). " has been uploaded";
     echo "<p>The URL is <b>http://www.ISC.tk/uploads/". $newfile . "</b></p>";
     echo "<p>To view your file visit <b>http://www.ISC.tk/uploads/browseupload.php?file=". $newfile . "</b></p>";
     echo "<p>We reserve the right to delete any file on our server.</p>";
     die( "<p><a href=\"Home.php\">Upload Another</a></p>");
} else{
     echo "There was an error uploading the file, please try again!";
     die( "<p><a href=\"Home.php\">Try Again</a></p>");
}
?>
 
Last edited:
Reply
0
0 Like
0 Thanks
•••
Log in or sign up to reply here.
Dynadot โ€” .com Registration $8.99Dynadot โ€” .com Registration $8.99

Similar threads

Barrucadu
File Upload Problem
13 replies
1K views
Barrucadu
Barrucadu
N
Need help
2 replies
747 views
qbert220
qbert220
S
Making a file hosting script. HELP!
10 replies
795 views
scousescott2k5
S
Barrucadu
This is a really noobish question...
7 replies
448 views
axilant
axilant
newsiness
FTP using PHP
3 replies
935 views
MJ
MJ

We're social

Escrow.com

New posts โž”

Spaceship

Auction activity โž”

Unstoppable Domains

How do you think a potential buyer first checks if your domain is for sale?

Polls of interest โž”

CryptoExchange.com

Hot this week โž”

Domain Recover

Community favorite โž”

Hot this month โž”

DomainEasy โ€” Live Options

Blog favorites

DomDB

  1. Sumac.net

    • Make Offer

  2. STU.US

    • Show Price

  3. haircolorspray.com

    • Make Offer

  4. LoveIsADiamond.com

    • Make Offer

  5. llzl.com

    • Buy Now
    • $2,000

  6. airesurrection.com

    • Make Offer

  7. Galore.co

    • Make Offer

  8. tecno.gr

    • Make Offer

  9. loungeant.io

    • Inquire

  10. oltren.com

    • Make Offer
  • The sidebar remains visible by scrolling at a speed relative to the pageโ€™s height.
Back