Preg_replace help needed! Lol

[PoorDoggie]

this dosen't seem to work:

$old_q = urldecode($_GET['q']);
    $spelling = "<b>Spelling Suggestion:</b> <a href=\"search.php?".preg_replace("/q=".urlencode($old_q)."/","q=".urlencode($result['ResultSet']['Result']),$_SERVER['QUERY_STRING'])."\">Did you mean <i><b>".$result['ResultSet']['Result']."</b></i></a><br /><br />";

This is a part of the spell checking script on 6YD search.

Can anyone help me? If $_GET['q'] is one word, then the spell check works a dream - ie: http://www.6yd.net/search.php?q=scool&m=web but when you have two words - ie: http://www.6yd.net/search.php?q=scool+lessons&m=web then it spells it correctly in the link's text, but it dosen't correct it in the url. The link and text are in the variable $spelling by the way.

Tom

 

[mikesherov]

do the urlencoding after of the preg_replace, not before! I believe that's right.

 

[PoorDoggie]

will have a go... stand by

nope - even as:

$old_q = $_GET['q'];
$spelling = "<b>Spelling Suggestion:</b> <a href=\"search.php?".preg_replace("/q=$old_q/","q=".urlencode($result['ResultSet']['Result']),$_SERVER['QUERY_STRING'])."\">Did you mean <i><b>".$result['ResultSet']['Result']."</b></i></a><br /><br />";

I still get the same results... The search.php page up on 6yd at the moment has the script above in it, not the origional.

I think it could have something to do with the fact that it is "word+word" in the querystring, but not in a variable or something... anyone got any ideas or a better way of going about it?

 

[PoorDoggie]

Please help... anyone!

 

[sacx13]

Reg ex.

I just tested on my computer and is working in this way:

preg_replace("/q=(.+?)&/",'q='.urlencode($result['ResultSet']['Result'])."&",$_SERVER['QUERY_STRING'])

replace your preg_replace with the above one.

Regards

 

[mikesherov]

Sorry, I meant you have to url_encode the $_GET[old_q] variable before the replace because the server string will have it encoded, and the get superglobal will have it decoded!

So simply change:

$old_q = $_GET['q'];

to

$old_q = urlencode($_GET['q']);

and instead of preg_replace, just use str_replace! It is a bit faster and should be used when you're doing a literal replacement instead of a pattern replacement.

 

[PoorDoggie]

aha! works - You are a lifesaver! :lol:

have some rep

Sorry, I meant you have to url_encode the $_GET[old_q] variable before the replace because the server string will have it encoded, and the get superglobal will have it decoded!

So simply change:

$old_q = $_GET['q'];

to

$old_q = urlencode($_GET['q']);

and instead of preg_replace, just use str_replace! It is a bit faster and should be used when you're doing a literal replacement instead of a pattern replacement.