Include help please!

[treyb]

Ok, Im using

<?php if (empty($page)) {
$page = "home.php"; 
}
if (file_exists("$page")) {
  include("$page");
} else {
  echo "<b>404</b> File not found.<br> We are sorry, the requested file cannot be found on our server.";
}
?>

And I try to type in my browser site.com/index.php?page=test.php and the page does not change to the other pages information...

 

[xrvel]

Actually your method does not really safe.
Lets modify it

<?php
$page = $_GET['page'];
$page = preg_replace('/([^a-z0-9\-\_]+)/i', '', $page);// remove unwanted char(s)
if (empty($page)) {
   $page = 'home'; 
}
$page .= '.php';// it must be a PHP file
if (file_exists("$page")) {
  include("$page");
} else {
  echo "<b>404</b> File not found.<br> We are sorry, the requested file cannot be found on our server.";
}
?>

 

[treyb]

thanks a million rep added!

 

[xrvel]

Almost forget,
use "site.com/index.php?page=test" instead of "site.com/index.php?page=test.php"

Good luck,
- Kurniawan.

 

[treyb]

lol i almost asked but then i thought about it and realized i was stupid for not noticing at the begining lol but thank goodness for trial and error lmao