Calculator
- Thread starter DJL2K
- Start date
The views expressed on this page by users and staff are their own, not those of NamePros.
lol just as I fixed it
You had
which will always be true and cause an infinite loop (hence why you had the max execution timeout, you also most likely had a huge screen with the equation repeated over and over).
You also had quotes around the echo lines that do the calculations and that was causing the mathematical symbol to be seen as a string instead of operator (hence why it just printed the equation instead of working out the answer)
lastly you did not check the existance of the post vars which causes an undefined index error if the form was not submitted. I havnt exactly fixed it but it will have helped.
If you wish to improve the script other things you can do is validate all user input to ensre it is as expected. For example numa and numb do not currently HAVE to be numbers although during the equation they should automatically be made into numbers (ie the letters stripped).
PHP:
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Calculator</title>
</head>
<body>
<form method="POST" action="<?php $_SERVER['PHP_SELF']; ?>">
<input type="text" name="numa" size="10">
<select name="operator">
<option>x</option>
<option>÷</option>
<option>+</option>
<option>-</option>
</select>
<input type="text" name="numb" size="10">
<input type="submit" value="Calculate" name="submit">
</form>
<?php
if(!empty($_POST['submit'])) {
$numa = $_POST['numa'];
$numb = $_POST['numb'];
$operator = $_POST['operator'];
$submit = $_POST['submit'];
if($operator == 'x') {
echo $numa * $numb;
}
elseif($operator == '÷') {
echo $numa / $numb;
}
elseif($operator == '+') {
echo $numa + $numb;
}
elseif($operator == '-') {
echo $numa - $numb;
}
}
?>
</body>
</html>You had
PHP:
while ($submit) {You also had quotes around the echo lines that do the calculations and that was causing the mathematical symbol to be seen as a string instead of operator (hence why it just printed the equation instead of working out the answer)
lastly you did not check the existance of the post vars which causes an undefined index error if the form was not submitted. I havnt exactly fixed it but it will have helped.
If you wish to improve the script other things you can do is validate all user input to ensre it is as expected. For example numa and numb do not currently HAVE to be numbers although during the equation they should automatically be made into numbers (ie the letters stripped).
Last edited:
Similar threads
New posts ➔
-
ileov.com - Just $25
- Post by Thoms1
-
Paoll.com - Just $50
- Post by Thoms1
-
CinemaClaw.com $16- Post by masbro
Polls of interest ➔
-
What are your strengths as an investor?- 186 voters
- 26 replies
-
What's your domain portfolio size?
- 464 voters
- 135 replies
-
How do you think a potential buyer first checks if your domain is for sale?- 510 voters
- 52 replies
Hot this week ➔
-
The AI Domain Hangover Might Be Good for the Market- 34 comments
- 43 points
-
Hello Dominers. I'd like your feedback on my new project and some support.- 30 replies
- 4 posters
-
The Real Reason Most Domain Portfolios Underperform
- 11 replies
- 5 points
-
World.xyz Sold for $80,000; HealthIq.com for $30,999...- 11 replies
- 8 points
-
TotalRX.com Sold For $75,000 At Sedo- 10 replies
- 21 points
Hot this month ➔
-
The $99 Experiment Is Teaching Me More About Domain Liquidity Than Appraisal Tools Ever Did
- 110 comments
- 52 points
-
Loading issues- 69 replies
- 7 points
-
AI vs. SI- 49 replies
- 17 points
-
WTB Robotics Domains .COM's Only
- 45 replies
- 37 posters
