What's wrong here? [Php]

[unknowngiver]

hey
i am not getting an error..it just doesnt show anything when it should

		function loadMedia($limit,$cid=-1)
		{
		$media = array();
		if ($cid == -1) {
		$where = "WHERE `status` = 1"; }
		$q = "SELECT * FROM `media` $where order by `timestamp` desc LIMIT 0,$limit";
		$result = $this->query($q);
		for ($b = 0; $b <(mysql_num_rows($result));$b++)
		{
			$db = mysql_fetch_array($result);
			$media[$b] = array($db['id'],$db['cat_id'],$db['by_id'],$db['file_name'],$db['dp'],$db['title'],
						$db['description'],$db['views'],$db['timestamp']);
		}
		return $media or die ("cant");;
		}

and then :

<?$media = $database->loadMedia(1); echo$media['0']['5'];?>

 

[Shorty]

It sounds like $cid != -1.

Either do "$cid = -1" before you call the function, or do it after $media = array();.

 

[Matthew.]

EDIT:
I didn't notice before.

Change:

return $media or die ("cant");;

To:

return $media;

That should fix it. With the 'or die' currently in the function, it will not be returning the array.


Possible Shorty but since he did not supply the second argument when using the function it should have been -1 by default. By it could be :P

Run this:

echo '<pre>';
print_r( $media )
echo '</pre>';

To see if the array is populated.

As a side note it does not matter in this case however you do not use '' for numerical array keys.

 

[Dan]

You should have had an error for an unexpected semi colon, too. When you are trying to find what's wrong, use error_reporting(E_ALL);

 

[Matthew.]

You should have had an error for an unexpected semi colon, too. When you are trying to find what's wrong, use error_reporting(E_ALL);

The extra semi colon wasn't the problem. (although could well have been in other cases)

I tried a little experiment since i didn't know 100% if it was the problem but:

function test($test) 
{
	$string = 'hi';
	
	if($test == true)
	{
		return $string or die('cant');
	}
	else
	{
		return $string;
	}
}

echo test(false);
// will output "hi"

echo test(true);
// will output "1"

Unsure as to why but adding the or die seems to return 1.

 

[ahtum]

Here i rewrote a little your code.

Hope it works

If it's not working then you might have problems with your the mysql class that you are using.

function loadMedia ( $limit , $cid = '-1' ){
	
	$media = array();
    
	if ($cid == '-1'){
    	$where = "WHERE `status` = 1";
	}else{
		$where = "";
	}
    
	$q = "SELECT * FROM `media` $where order by `timestamp` desc LIMIT 0,$limit";
    $result = $this->query($q);
    
	$db = mysql_fetch_array($result);
	
	for ($b = 0; $b <(mysql_num_rows($result));$b++){
            
    	$media[$b] = array	(	$db['id'],$db['cat_id'],$db['by_id'],$db['file_name'],$db['dp'],
								$db['title'],$db['description'],$db['views'],$db['timestamp']
							);
    }
	
	return $media;
}

 

[Dan]

If you change

if($test == true)
to
if($test === true)

it will run just return $string;

I can't figure out why it makes it return 1..
"void exit ( [string status] )"



Ahtum, you need to have it get the row inside of the for loop to get all of the rows. What you did would only get one.

 

[Matthew.]

If you change

if($test == true)
to
if($test === true)

it will run just return $string;

No it wont? :hehe:

 

[Dan]

No it wont? :hehe:

... not if you use true... He's not using true as the input, so your test doesn't necessarily do anything except for showing that it's weird how it returns 1.

 

[Matthew.]

... not if you use true... He's not using true as the input, so your test doesn't necessarily do anything except for showing that it's weird how it returns 1.

Which was the aim of my test The conditional is irrelevant, it was just to make it easier to swap between the 2 (I'm bored gimme a break.)

function test($string) 
{
	return $string or die("cant");
}

:hehe:

I'm determined to find out why it returns 1...

 

[Amnezia]

Which was the aim of my test The conditional is irrelevant, it was just to make it easier to swap between the 2 (I'm bored gimme a break.)

function test($string) 
{
	return $string or die("cant");
}

:hehe:

I'm determined to find out why it returns 1...

return is a langauge construct not a function therefore it does not return an exit code.

in other words

return $somestring or die("some message") is a pointless line of code

 

[Matthew.]

return is a langauge construct not a function therefore it does not return an exit code.

in other words

return $somestring or die("some message") is a pointless line of code

That i know (which is why i said remove it from the original code)

My point/query was why it returns 1 :P It is not important, merely something i was wondering :P