$_Session help

unknowngiver · Dec 6, 2006

Hey
as i said in a previous thread, i am learning php and i am trying to make a "Guess the number" game..but everytime the browser refreshes/user inputs a number ..the random number changes..i am using sessions but it still doesnt work..can anyone help?
heres the code:

PHP:

<?php
session_start();
$user_guess = (int)$_POST[guess];
if (empty($_Session['number'])) { 
$_Session['number'] = rand(1,100);

}
$num_to_guess = $_Session['number'];

$message ="";
$counter = 0;
if (!isset($user_guess)){
	$message="Welcome to the guessing machine!";
	}
else if ($user_guess > $num_to_guess) {
	$message = "$user_guess is too big! try a smaller number";
	$counter++;
 }
else if ($user_guess < $num_to_guess) {
	$message = "$user_guess is too small! try a bigger number";
	$counter++;
	}
else {
	$message = "Well done! it tool you $counter times to get the right number";
     }

?>		
<html>
<head>
<title>Number</title</head>
<body>
<p><h1><?php echo $message; ?> </h1></p>
<form action="<?php echo $_SERVER[PHP_SELF]; ?>" method="POST">
<p>Guess: <input type="text" name="guess"></p>
</p><input type="submit" value="submit your guesS"></p>
</form>
</body>
</html>

Dan · Dec 6, 2006

Try changing them from $_Session to $_SESSION

unknowngiver · Dec 6, 2006

lol yup that was the problem :p
Thanks

Tree · Dec 6, 2006

On an unrelated note, you forgot to close your <title> tag properly.

Dan · Dec 6, 2006

Another unrelated note: "Well done! it tool you $counter times to get the right number";

Tree · Dec 6, 2006

Another unrelated note: you close a <p> tag before it's opened.

Code:

</p><input type="submit" value="submit your guesS"></p>

Eh, I had nothing to do. Fixed.

PHP:

<?php
session_start();
$user_guess = (int)$_POST[guess];
if (empty($_SESSION['number'])) { 
$_SESSION['number'] = rand(1,100);

}
$num_to_guess = $_SESSION['number'];

$message ="";
$counter = 0;
if (!isset($user_guess)){
    $message="Welcome to the guessing machine!";
    }
else if ($user_guess > $num_to_guess) {
    $message = "$user_guess is too big! try a smaller number";
    $counter++;
 }
else if ($user_guess < $num_to_guess) {
    $message = "$user_guess is too small! try a bigger number";
    $counter++;
    }
else {
    $message = "Well done! it took you $counter times to get the right number";
     }

?>        
<html>
<head>
<title>Number</title></head>
<body>
<p><h1><?=$message?> </h1></p>
<form action="?" method="POST">
<p>Guess: <input type="text" name="guess"></p>
<p><input type="submit" value="Submit Your Guess"></p>
</form>
</body>
</html>

Dan · Dec 6, 2006

Another unrelated note: your input's aren't valid XHTML. (That's the best I could do.. I think that's it.)

edit: I got another one if Tree is done.

edit2: It seems like he is, so:
Another unrelated note: $counter will always be 0 when the person finishes. You need to make that a session variable and increment it when its wrong and not set it to 0 every time unless it's not set.

unknowngiver · Dec 6, 2006

lol thanks for the notes guyz..its just a fun test game and i m no where close 2 done:p anyway i got another small problem
it never shows this message:

$message="Welcome to the guessing machine!";

Dan · Dec 6, 2006

$user_guess = (int)$_POST[guess];
if (!isset($user_guess)){

You set it.. you need to check if it is empty.

unknowngiver · Dec 6, 2006

okay awesome

heres the new code
p.s: dan: whats xhtml valid form thing u were tellign me about?

PHP:

<?php
	session_start(); // Starts the session
	if (empty($_SESSION['number'])) { 
		$_SESSION['number'] = rand(1,100);
	}

	if(empty($counter)) {
		$_SESSION['count'] = 1;
	}

	# Variables
	$num_to_guess = $_SESSION['number']; // Random number
	$message =""; 
	$user_guess = (int)$_POST[guess];
	$counter=$_SESSION['count'];
	
	if (empty($user_guess)){
    		$message="Welcome to the guessing machine!";
    	}
	else if ($user_guess > $num_to_guess) {
    		$message = "$user_guess is too big! try a smaller number";
    		$counter++;
 	}
	else if ($user_guess < $num_to_guess) {
    		$message = "$user_guess is too small! try a bigger number";
    		$counter++;
    	}
	else {
    		$message = "Well done! it took you ".++$counter." times to get the right number";
		unset($_SESSION['number']);
		unset($_SESSION['Count']);
     	}

?>
        
<html>
<head>
	<title>Number</title>
</head>
<body>

	<p><h1><?=$message?> </h1></p>
	<form action="?" method="POST">
		<p>Guess: <input type="text" name="guess"></p>
		<p><input type="submit" value="Submit Your Guess"></p>
	</form>

</body>
</html>

however, now the counter has problems..it alwayz display 2 for the counter

Dan · Dec 6, 2006

PHP:

<?php

session_start(); // Starts the session
if (empty($_SESSION['number'])) { 
	$_SESSION['number'] = rand(1,100);
}

if (empty($_SESSION['count'])) {
	$_SESSION['count'] = 1;
} else {
	if (!empty($_POST['guess'])) $_SESSION['count']++; 
}

$num_to_guess = $_SESSION['number']; // Random number
$message      = ""; 
$user_guess   = (int)$_POST[guess];
$counter      = $_SESSION['count'];

if (empty($user_guess)){
	$message="Welcome to the guessing machine!";
} elseif ($user_guess > $num_to_guess) {
	$message = "$user_guess is too big! Try a smaller number";
	$counter++;
} elseif ($user_guess < $num_to_guess) {
	$message = "$user_guess is too small! Try a bigger number";
	$counter++;
} else {
	$message = "Well done! It took you ".--$counter." times to get the right number";
	unset($_SESSION['number']);
	unset($_SESSION['count']);
}

?>
        
<html>
<head>
    <title>Number</title>
</head>
<body>
    <p><h1><?=$message?></h1></p>
    <form action="?" method="POST">
        <p>Guess: <input type="text" name="guess" /></p>
        <p><input type="submit" value="Submit Your Guess" /></p>
    </form>
</body>
</html>

You just need to watch variable names and use the correct case. Other than a few errors like counter instead of count, the script would work good.

unknowngiver · Dec 7, 2006

hey
thanks dan

i got another problem though..if user inputs 0 it shows them the "Welcome" message
i dont know why it does it..i guess 0 = empty? how do i fix that

sukantab · Dec 7, 2006

Try this:
Modified the code a bit...

PHP:

<?php 

session_start(); // Starts the session 
$message      = "";  
$counter      = $_SESSION['count']; 
if (!isset($_SESSION['done'])) {
   $message="Welcome to the guessing machine!";
}
else if ($_SESSION['done'] = 1) {
if ($_POST[guess] = 0) {
    $message = "$user_guess is too small! Try a bigger number"; 
    $counter++;
}
if (empty($_SESSION['number'])) {  
    $_SESSION['number'] = rand(1,100); 
} 

if (empty($_SESSION['count'])) { 
    $_SESSION['count'] = 1; 
} else { 
    if (!empty($_POST['guess'])) $_SESSION['count']++;  
} 

$num_to_guess = $_SESSION['number']; // Random number 
$user_guess   = (int)$_POST[guess]; 

if (empty($user_guess)){ 
    $message="Welcome to the guessing machine!"; 
} elseif ($user_guess > $num_to_guess) { 
    $message = "$user_guess is too big! Try a smaller number"; 
    $counter++; 
} elseif ($user_guess < $num_to_guess) { 
    $message = "$user_guess is too small! Try a bigger number"; 
    $counter++; 
} else { 
    $message = "Well done! It took you ".--$counter." times to get the right number"; 
    unset($_SESSION['number']); 
    unset($_SESSION['count']); 
} 
}

?> 
         
<html> 
<head> 
    <title>Number</title> 
</head> 
<body> 
    <p><h1><?=$message?></h1></p> 
    <form action="?" method="POST"> 
        <p>Guess: <input type="text" name="guess" value="<?PHP ECHO $_POST[guess]; ?>"/></p> 
        <p><input type="submit" value="Submit Your Guess" /></p> 
        <input type="hidden" name="done" value="1" />
    </form> 
</body> 
</html>

unknowngiver · Dec 7, 2006

now it alwayz shows "Welcome to the guessing machine"

Dan · Dec 7, 2006

sukantab, what's the point of $_SESSION['done'];? I don't really see what any of that does other than add an if statement.

unknowngiver, the code I posted worked fine and did everything you wanted it to, right?

unknowngiver · Dec 7, 2006

Dan: yes but if you enter "0" it gives the welcome message again..instead of saying "number is 2 small"..

$_Session help

VIP Member

Buy my domains.VIP Member

VIP Member

Established Member

Buy my domains.VIP Member

Established Member

Buy my domains.VIP Member

VIP Member

Buy my domains.VIP Member

VIP Member

Buy my domains.VIP Member

VIP Member

Established Member

VIP Member

Buy my domains.VIP Member

VIP Member

RenewMe.com

Reveel.io

Generating.com

LikeBoost.com

Brand.so

infinixmobiles.com

Aero.me

Live.Events

Business.News

Chat.si

Similar threads

We're social

RenewMe.com

Reveel.io

Generating.com

LikeBoost.com

Brand.so

infinixmobiles.com

Aero.me

Live.Events

Business.News

Chat.si

Pinned

Appreciation

Preference

Appreciation

Upvoting

Agreement

Answers

Decisions

Relevance

Reaction

Facial expressions

Vocal expressions

Status

Workflow

Clarification

Feeling

Sympathy