include help please!

treyb · 03-10-2008, 09:11 PM

Ok, Im using

PHP Code:

  <?php if (empty($page)) {

$page = "home.php"; 

????: NamePros.com http://www.namepros.com/programming/442956-include-help-please.html
}

if (file_exists("$page")) {

  include("$page");

} else {

  echo "<b>404</b> File not found.<br> We are sorry, the requested file cannot be found on our server.";

}

?>

And I try to type in my browser site.com/index.php?page=test.php and the page does not change to the other pages information...

xrvel · 03-10-2008, 09:38 PM

Actually your method does not really safe.
????: NamePros.com http://www.namepros.com/showthread.php?t=442956
Lets modify it

PHP Code:

  <?php

$page = $_GET['page'];

$page = preg_replace('/([^a-z0-9\-\_]+)/i', '', $page);// remove unwanted char(s)

if (empty($page)) {

   $page = 'home'; 

}

$page .= '.php';// it must be a PHP file

if (file_exists("$page")) {

  include("$page");

} else {

  echo "<b>404</b> File not found.<br> We are sorry, the requested file cannot be found on our server.";

}

?>

treyb · 03-10-2008, 09:50 PM

thanks a million rep added!

xrvel · 03-10-2008, 09:56 PM

Almost forget,
use "site.com/index.php?page=test" instead of "site.com/index.php?page=test.php"

Good luck,
- Kurniawan.

treyb · 03-10-2008, 10:16 PM

lol i almost asked but then i thought about it and realized i was stupid for not noticing at the begining lol but thank goodness for trial and error lmao

03-10-2008, 09:11 PM	THREAD STARTER #1 (permalink)
treyb DixieTalk.com Join Date: Jan 2008 Posts: 244 Follow @dixietalk	include help please! Ok, Im using PHP Code: `<?php if (empty($page)) { $page = "home.php"; ????: NamePros.com http://www.namepros.com/programming/442956-include-help-please.html } if (file_exists("$page")) { include("$page"); } else { echo "<b>404</b> File not found.<br> We are sorry, the requested file cannot be found on our server."; } ?>` And I try to type in my browser site.com/index.php?page=test.php and the page does not change to the other pages information...

03-10-2008, 09:38 PM	#2 (permalink)
xrvel i love automation Join Date: Nov 2007 Location: xrvel.com Posts: 1,620 Follow @xrvel	Actually your method does not really safe. ????: NamePros.com http://www.namepros.com/showthread.php?t=442956 Lets modify it PHP Code: `<?php $page = $_GET['page']; $page = preg_replace('/([^a-z0-9\-\_]+)/i', '', $page);// remove unwanted char(s) if (empty($page)) { $page = 'home'; } $page .= '.php';// it must be a PHP file if (file_exists("$page")) { include("$page"); } else { echo "<b>404</b> File not found.<br> We are sorry, the requested file cannot be found on our server."; } ?>` __________________ Xrvel \| Free Wordpress Plugins \| Desain \| Bodoh \| WP License

03-10-2008, 09:56 PM	#4 (permalink)
xrvel i love automation Join Date: Nov 2007 Location: xrvel.com Posts: 1,620 Follow @xrvel	Almost forget, use "site.com/index.php?page=test" instead of "site.com/index.php?page=test.php" Good luck, - Kurniawan. __________________ Xrvel \| Free Wordpress Plugins \| Desain \| Bodoh \| WP License

03-10-2008, 09:50 PM	THREAD STARTER #3 (permalink)
treyb DixieTalk.com Join Date: Jan 2008 Posts: 244 Follow @dixietalk	thanks a million rep added!

03-10-2008, 10:16 PM	THREAD STARTER #5 (permalink)
treyb DixieTalk.com Join Date: Jan 2008 Posts: 244 Follow @dixietalk	lol i almost asked but then i thought about it and realized i was stupid for not noticing at the begining lol but thank goodness for trial and error lmao

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)