Javascript and php confusion

champ_rock · 05-30-2007, 01:35 AM

hello

i am here once again with my problems

i have a php variable containing a URL -- $url

what i want to do is to open a new window opening the URL specified in $url

here is my code to generate a new window

Code:

		echo '<SCRIPT LANGUAGE="JavaScript"><!-- Begin 
		window.open ("$url") 
					// End --></script>';

the above does not work as the browser takes $url as a string and tries to open the relative path
????: NamePros.com http://www.namepros.com/programming/333460-javascript-and-php-confusion.html

i have tried variation such as \"$url"\ but this give me some ASCII error

please guide me on where i am going wrong

klstrphnky · 05-30-2007, 02:12 AM

It is not a very elegant solution, but must work:

PHP Code:

  window.open ("'.$url.'") 

????: NamePros.com http://www.namepros.com/showthread.php?t=333460

Peter · 05-30-2007, 11:43 AM

The reason it does not work is because the variable is in single quotes. Variables in sibngle quotes are treated as strings. To have them evaluated properly use double quotes or as klstrphnky suggests use concatenation (my favourite of the 2 methods)

samuofm · 05-30-2007, 12:21 PM

Since javascript can use either single or double quotes, you just put the string together like this
????: NamePros.com http://www.namepros.com/showthread.php?t=333460

PHP Code:

   
    echo "<script language='JavaScript'> window.open ('" . $url . "'); </script>";

effectively you are concatenating 3 strings and this would be equivalent (easier to understand maybe)

PHP Code:

  $i = "<script language='JavaScript'> window.open ('";

$i .= $url;

$i .= "'); </script>"; 

 
echo i$;

Dan · 05-30-2007, 01:01 PM

If you're going to use double quotes, you can do

PHP Code:

   echo "<script language='JavaScript'> window.open ('$url') </script>"; 

????: NamePros.com http://www.namepros.com/showthread.php?t=333460

samuofm · 05-30-2007, 01:23 PM

also i recommend you add a semi colon in your javascript call (see my example), its optional with only one statement like you have here but its a good practice for when you change the code later.

cef · 05-30-2007, 05:09 PM

Originally Posted by samuofm

also i recommend you add a semi colon in your javascript call (see my example), its optional with only one statement like you have here but its a good practice for when you change the code later.

Actually, you can leave off semicolons altogether if each statement is on its own line, but I've never seen anyone code this way. At least not intentionally.

champ_rock · 05-30-2007, 08:25 PM

thanks a lot guys

reps for all of u

neroux · 05-31-2007, 01:41 AM

The best way would be still to actually embed PHP into HTML.

HTML Code:

<script language='JavaScript'>window.open('<?php echo $url; ?>');</script>

samuofm · 05-31-2007, 01:54 PM

Originally Posted by neroux

The best way would be still to actually embed PHP into HTML.

HTML Code:

<script language='JavaScript'>window.open('<?php echo $url; ?>');</script>

You can argue either way depending on how his app is laid out. Embedded php is ok for presentation logic, but you really want to stay away from it for business logic, and its its possible that echo would only be used after a certain business logic method was called. It also becomes harder to read embedded php when you have multiple levels of nested ifs.

For example, here is some embedded php I wrote that makes use of nested ifs and it begins to become difficult to read.

PHP Code:

  
????: NamePros.com http://www.namepros.com/showthread.php?t=333460
<?php if ($qeiObj->formData['fireplaceMantel'] == 'on') { ?>

 
  <div>Type of mantle: <?php echo $qeiObj->formData['mantelType']; ?> </div>

 
 
  <div>Spindles to paint on banister: <?php

    if ($qeiObj->formData['numSpindles'] != 20) {

????: NamePros.com http://www.namepros.com/showthread.php?t=333460
      echo $qeiObj->formData['numSpindles'];

    }

    else {

      echo "20+";

    }

  ?></div>

 
<?php } ?>

that's fairly hard to read with just two levels, and if I replaced those inner echoes with embedded php it would be even more challenging.

05-30-2007, 01:35 AM	THREAD STARTER #1 (permalink)
champ_rock Senior Member Join Date: Oct 2006 Location: http://akshayjain.org Posts: 2,817	Javascript and php confusion hello i am here once again with my problems i have a php variable containing a URL -- $url what i want to do is to open a new window opening the URL specified in $url here is my code to generate a new window Code: echo '<SCRIPT LANGUAGE="JavaScript"><!-- Begin window.open ("$url") // End --></script>'; the above does not work as the browser takes $url as a string and tries to open the relative path ????: NamePros.com http://www.namepros.com/programming/333460-javascript-and-php-confusion.html i have tried variation such as \"$url"\ but this give me some ASCII error please guide me on where i am going wrong

05-30-2007, 02:12 AM	#2 (permalink)
klstrphnky NamePros Regular Join Date: Jul 2006 Posts: 333	It is not a very elegant solution, but must work: PHP Code: `window.open ("'.$url.'") ????: NamePros.com http://www.namepros.com/showthread.php?t=333460`

05-30-2007, 12:21 PM	#4 (permalink)
samuofm New Member Join Date: Mar 2007 Posts: 16	Since javascript can use either single or double quotes, you just put the string together like this ????: NamePros.com http://www.namepros.com/showthread.php?t=333460 PHP Code: `echo "<script language='JavaScript'> window.open ('" . $url . "'); </script>";` effectively you are concatenating 3 strings and this would be equivalent (easier to understand maybe) PHP Code: `$i = "<script language='JavaScript'> window.open ('"; $i .= $url; $i .= "'); </script>"; echo i$;` Last edited by samuofm; 05-30-2007 at 01:22 PM.

05-30-2007, 01:01 PM	#5 (permalink)
Dan Buy my domains. Join Date: Feb 2006 Posts: 2,792	If you're going to use double quotes, you can do PHP Code: `echo "<script language='JavaScript'> window.open ('$url') </script>"; ????: NamePros.com http://www.namepros.com/showthread.php?t=333460`

05-31-2007, 01:41 AM	#9 (permalink)
neroux NamePros Regular Join Date: Oct 2006 Posts: 972	The best way would be still to actually embed PHP into HTML. HTML Code: <script language='JavaScript'>window.open('<?php echo $url; ?>');</script> __________________ Paris loves CityPics -- Do not let others be treated this way!

05-30-2007, 11:43 AM	#3 (permalink)
Peter NamePros Expert Join Date: Nov 2003 Location: Scotland Posts: 5,074	The reason it does not work is because the variable is in single quotes. Variables in sibngle quotes are treated as strings. To have them evaluated properly use double quotes or as klstrphnky suggests use concatenation (my favourite of the 2 methods)

05-30-2007, 01:23 PM	#6 (permalink)
samuofm New Member Join Date: Mar 2007 Posts: 16	also i recommend you add a semi colon in your javascript call (see my example), its optional with only one statement like you have here but its a good practice for when you change the code later.

05-30-2007, 08:25 PM	THREAD STARTER #8 (permalink)
champ_rock Senior Member Join Date: Oct 2006 Location: http://akshayjain.org Posts: 2,817	thanks a lot guys reps for all of u

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)