PHP code not working

unixbro-patty · 05-09-2005, 08:37 AM

Code:

$connection = mysql_connect("localhost", "$user", "$password") or die("Couldn't connect to database");

$db = mysql_select_db($database, $connection) or die("Couldn't choose database.");

$sql = mysql_query("INSERT INTO $table_name (first_name, last_name, birthdate, address, city, state, zip, phone) VALUES ('$first_name', '$last_name', '$birthdate', '$address', '$city', '$state', '$zip', '$phone')");

can someone tell me why the above code isn't putting anything inat a database except the int and date defaults?

adam_uk · 05-09-2005, 09:02 AM

delete the $sql = bit

what your doing is putting that the query function to a variable but not calling the variable afterwards.

what you could do is

PHP Code:

  $sql = "MY MYSQL `query` HERE"

mysql_query($sql);

eagle12 · 05-09-2005, 10:39 AM

We need to see more of the code to try and figure out the problem.

axilant · 05-09-2005, 12:21 PM

not sure but if you are getting this info from a form posting with method of POST or GET:

PHP Code:

  $connection = mysql_connect("localhost", "$user", "$password") or die("Couldn't connect to database");

 
$db = mysql_select_db($database, $connection) or die("Couldn't choose database.");

 
$sql = mysql_query("INSERT INTO $table_name (first_name, last_name, birthdate, address, city, state, zip, phone) VALUES ('$_POST[first_name]', '$_POST[last_name]', '$_POST[birthdate]', '$_POST[address]', '$_POST[city]', '$_POST[state]', '$_POST[zip]', '$_POST[phone]')");

This will also be a little more secure.
if your using the GET method change _POST to _GET.

Cody Selzer

PoorDoggie · 05-09-2005, 02:16 PM

you could add this code:

PHP Code:

  if( !$sql ){

echo "Could not add to database";

}

this will run the mysql query AND report on any errors.

lol

Dunno if this will work though.

RJ · 05-09-2005, 02:46 PM

The part you posted looks fine, unixbro. Would have to see the whole script to see what's not working right.

eagle12 · 05-09-2005, 05:07 PM

It sounds like you don't have anything being stored in the variables you trying to insert into the DB. As RJ said, and I said earlier, we need to see more code.

unixbro-patty · 05-11-2005, 05:47 PM

Code:

<?php
$db_name = "xxxxxxx";
$username = "xxxxxx";
$password = "xxxxxx";
$tbl_name = "xxxxxx";
$connection = mysql_connect("localhost", "$username", "$password") or die("Couldn't connect to database");
$db = mysql_select_db($db_name, $connection) or die("Couldn't choose database.");
$sql = mysql_query("INSERT INTO $tbl_name (first_name, last_name, birthdate, address, city, state, zip, phone) VALUES ('$first_name', '$last_name', '$birthdate', '$address', '$city', '$state', '$zip', '$phone')");
mysql_query($sql);
$result = mysql_query($sql, $connection);
if (!$result) {
   die('Could not query:' . mysql_error());
}
else { 
   die('Data entered correctly.');
}

?>
<html>
<title>Database connect</title>
<body>
<? 
echo "$msg"; 
echo "<p>First Name: $first_name <br>";
echo "<p>Last Name: $last_name <br>";
echo "<p>Birthdate: $birthdate <br>";
echo "<p>Address: $address <br>";
echo "<p>City: $city <br>";
echo "<p>State: $state <br>";
echo "<p>Zip: $zip <br>";
echo "<p>Phone: $phone <br>";
?>
</body>
</html>

There's the whole code still not working

axilant · 05-11-2005, 05:49 PM

odd, wheres the form?

PHP Code:

  <?php

$db_name = "xxxxxxx";

$username = "xxxxxx";

$password = "xxxxxx";

$tbl_name = "xxxxxx";

$connection = mysql_connect("localhost", "$username", "$password") or die("Couldn't connect to database");

$db = mysql_select_db($db_name, $connection) or die("Couldn't choose database.");

$sql = @mysql_query("INSERT INTO $tbl_name (first_name, last_name, birthdate, address, city, state, zip, phone) VALUES ('$first_name', '$last_name', '$birthdate', '$address', '$city', '$state', '$zip', '$phone')") OR DIE(mysql_error());

 
 
 
?>

<html>

<title>Database connect</title>

<body>

<? 

echo "$msg"; 

echo "<p>First Name: $first_name <br>";

echo "<p>Last Name: $last_name <br>";

echo "<p>Birthdate: $birthdate <br>";

echo "<p>Address: $address <br>";

echo "<p>City: $city <br>";

echo "<p>State: $state <br>";

echo "<p>Zip: $zip <br>";

echo "<p>Phone: $phone <br>";

?>

</body>

</html>

unixbro-patty · 05-11-2005, 06:40 PM

axilant ... thanks man it works now. and you helped me learn I appreciate it

axilant · 05-11-2005, 07:38 PM

Quote:

Originally Posted by unixbro

axilant ... thanks man it works now. and you helped me learn I appreciate it

im pleased to hear you compliment me like that

and no problem hit me on any instant messager if you need help (check profile)

05-09-2005, 12:21 PM	#4 (permalink)
axilant Account Closed Join Date: May 2004 Location: /etc/passwd Posts: 2,194 0.00 NP$ (Donate)	not sure but if you are getting this info from a form posting with method of POST or GET: PHP Code: `$connection = mysql_connect("localhost", "$user", "$password") or die("Couldn't connect to database"); $db = mysql_select_db($database, $connection) or die("Couldn't choose database."); $sql = mysql_query("INSERT INTO $table_name (first_name, last_name, birthdate, address, city, state, zip, phone) VALUES ('$_POST[first_name]', '$_POST[last_name]', '$_POST[birthdate]', '$_POST[address]', '$_POST[city]', '$_POST[state]', '$_POST[zip]', '$_POST[phone]')");` This will also be a little more secure. if your using the GET method change _POST to _GET. Cody Selzer

05-09-2005, 02:16 PM	#5 (permalink)
PoorDoggie Soon to be RICHdoggie! Join Date: Jan 2005 Location: UK Posts: 2,390 316.50 NP$ (Donate)	you could add this code: PHP Code: `if( !$sql ){ echo "Could not add to database"; }` this will run the mysql query AND report on any errors. lol Dunno if this will work though. __________________ █ Exchange your long URL for a much smaller one! █ Free Anonymizer/Proxy █ Taz Martin's blog - Learn all about internet marketing, promoting your website and much more!

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Tutorial: Getting started with PHP (The Basics)	deadserious	Webmaster Tutorials	60	11-17-2007 11:35 AM
Googlism - What does google think of you?	deadserious	The Break Room	55	12-15-2005 09:09 AM
Basic HTML Tutorial	webgear	Webmaster Tutorials	8	04-02-2005 02:20 PM

05-09-2005, 09:02 AM	#2 (permalink)
adam_uk Senior Member Join Date: May 2003 Posts: 2,211 6,170.25 NP$ (Donate)	delete the $sql = bit what your doing is putting that the query function to a variable but not calling the variable afterwards. what you could do is PHP Code: $sql = "MY MYSQL `query` HERE" mysql_query($sql);

05-09-2005, 10:39 AM	#3 (permalink)
eagle12 NamePros Member Join Date: Nov 2003 Location: Ontario, Canada Posts: 91 80.80 NP$ (Donate)	We need to see more of the code to try and figure out the problem.

05-09-2005, 02:46 PM	#6 (permalink)
RJ NamePros Founder Administrator Join Date: Feb 2003 Location: Bay Area, CA Posts: 13,173 104,451.68 NP$ (Donate)	The part you posted looks fine, unixbro. Would have to see the whole script to see what's not working right.

05-09-2005, 05:07 PM	#7 (permalink)
eagle12 NamePros Member Join Date: Nov 2003 Location: Ontario, Canada Posts: 91 80.80 NP$ (Donate)	It sounds like you don't have anything being stored in the variables you trying to insert into the DB. As RJ said, and I said earlier, we need to see more code.

05-11-2005, 05:49 PM	#9 (permalink)
axilant Account Closed Join Date: May 2004 Location: /etc/passwd Posts: 2,194 0.00 NP$ (Donate)	odd, wheres the form? PHP Code: <?php $db_name = "xxxxxxx"; $username = "xxxxxx"; $password = "xxxxxx"; $tbl_name = "xxxxxx"; $connection = mysql_connect("localhost", "$username", "$password") or die("Couldn't connect to database"); $db = mysql_select_db($db_name, $connection) or die("Couldn't choose database."); $sql = @mysql_query("INSERT INTO $tbl_name (first_name, last_name, birthdate, address, city, state, zip, phone) VALUES ('$first_name', '$last_name', '$birthdate', '$address', '$city', '$state', '$zip', '$phone')") OR DIE(mysql_error()); ?> <html> <title>Database connect</title> <body> <? echo "$msg"; echo "<p>First Name: $first_name <br>"; echo "<p>Last Name: $last_name <br>"; echo "<p>Birthdate: $birthdate <br>"; echo "<p>Address: $address <br>"; echo "<p>City: $city <br>"; echo "<p>State: $state <br>"; echo "<p>Zip: $zip <br>"; echo "<p>Phone: $phone <br>"; ?> </body> </html>

05-11-2005, 06:40 PM	#10 (permalink)
unixbro-patty Account Closed Join Date: May 2005 Posts: 62 117.25 NP$ (Donate)	axilant ... thanks man it works now. and you helped me learn I appreciate it

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)

Administrator