PHP uploading problems

mholt · 03-03-2007, 01:01 PM

Hello...

I have an upload script that I found online (I've only worked with uploads once in my life, and it didn't involve image resizing):

PHP Code:

  /*== only resize if the image is larger than 660 x 1000 ==*/

    $imgsize = GetImageSize($imgfile);

 
    /*== check size  0=width, 1=height ==*/

    if (($imgsize[0] > 660) || ($imgsize[1] > 1000))

    {

        /*== temp image file -- use "tempnam()" to generate the temp

             file name. This is done so if multiple people access the

            script at once they won't ruin each other's temp file ==*/

        $tmpimg = tempnam("/tmp", "MKUP");

 
        /*== RESIZE PROCESS

             1. decompress jpeg image to pnm file (a raw image type)

             2. scale pnm image

             3. compress pnm file to jpeg image

        ==*/

 
        /*== Step 1: djpeg decompresses jpeg to pnm ==*/

        system("djpeg $imgfile >$tmpimg");

 
 
        /*== Steps 2&3: scale image using pnmscale and then

             pipe into cjpeg to output jpeg file ==*/

        system("pnmscale -xy 660 1000 $tmpimg | cjpeg -smoo 10 -qual 50 >$imgfile");

 
        /*== remove temp image ==*/

        unlink($tmpimg);

 
    }

 
    /*== setup final file location and name ==*/

    /*== change spaces to underscores in filename  ==*/

    $final_filename = str_replace(" ", "_", $imgfile_name);

    $newfile = $uploaddir . "/$final_filename";

 
    /*== delete the temporary uploaded file ==*/

    unlink($imgfile);

 
 
    //print("<img src=\"$final_filename\">");

 
 
    /*== do extra security check to prevent malicious abuse==*/

    if (is_uploaded_file($imgfile))

    {

 
       /*== move file to proper directory ==*/

       if (!copy($imgfile,"$newfile"))

       {

          /*== if an error occurs the file could not

               be written, read or possibly does not exist ==*/

          print "Error Uploading File.";

          exit();

       }

     }

The error comes on the line with the unlink($tmpimg) function at the end of the resizing where it deletes the temporary file. It says there's no such file or directory, yet there's no other errors given out.

Any help appreciated

Thanks.

.chulium.

(I didn't include *ALL* of the code, like the form, etc, but everything else is working fine. I've spent hours trying to debug this script... trust me on the previous code: it's good.)

Dan · 03-03-2007, 01:08 PM

You probably don't need to have that line.. it's a temp file and will probably be deleted anyways.

iNod · 03-03-2007, 01:10 PM

You don't need to delete the tmp file. The server will do it for you and PHP cannot access the /tmp folder. Does it work otherwise?

- Steve

mholt · 03-03-2007, 01:15 PM

No, the upload doesn't work at all... I CHMOD'ed everything to 777 (well, everything being the upload directory I made)...

smilgy · 03-04-2007, 11:39 AM

did u put <php? in front of the script and ?> at the end?

mholt · 03-04-2007, 11:52 AM

I did of course

Any other ideas? :-/

lfhost · 03-04-2007, 01:42 PM

1, where are you defining the $_FILE ? all I see is $imgfile
2, does your server support Imagemajik/system() commands?
3, is $uploaddir set anywhere and to the same folder you have chmodd?
4, Have you tried dumping what is uploaded i.e.

PHP Code:

  print_r($_FILES);

5, You may want to show your form to make sure you are allowing the enctype upload.

mholt · 03-04-2007, 03:44 PM

This might be easier... here's my whole code:

PHP Code:

  <?php

 
include("functions.php");

 
function getFileExtension($str) {

$i = strrpos($str,".");

if (!$i) { return ""; }

 
$l = strlen($str) - $i;

$ext = substr($str,$i+1,$l);

return $ext;

}

 
if (!$_GET['go'])

{

?>

<html>

<head>

<title>Upload New Picture</title>

</head>

<body>

<h1>Upload New Photograph</h1>

 
(Max file size: 2.0 MB)<br><br>

<form method="post" action="newimg.php?go=true" enctype="multipart/form-data" id="mf" name="mf">

<input type="hidden" name="MAX_FILE_SIZE" value="2000000">

Image: <input type="file" name="imgfile">

<br><br>

Caption: <input type="text" size="40" maxlength="100" name="title">

<br><br>

Description: <textarea cols="40" rows="5" name="des"></textarea>

<br><br>

Category: <select size="1" name="catid">

<option value="" SELECTED></option>

<?php

$q = mysql_query("SELECT * FROM categories ORDER BY title ASC");

$i = 0;

while ($r = mysql_fetch_array($q))

{

    $title = stripslashes($r['title']);

    $id = $r['id'];

?>

<option value="<?php echo($id); ?>"><?php echo($title); ?></option>

<?php

}

?>

</select>

<br><br>

Make Category Thumbnail? <select size="1" name="catrep">

<option value="No" SELECTED>No</option>

<option value="Yes">Yes</option>

</select>

<br><br>

Comments: <select size="1" name="comments">

<option value="On" SELECTED>On</option>

<option value="Off">Off</option>

</select>

<br><br>

<input type="submit" value="Upload Image" id="sbt" onClick="this.disabled=true;return true;"> &nbsp; <a href="main.php">Menu</a>

</form>

 
<br><br><br>

 
(c) 2007 ****.

 
</body>

</html>

<?php

}

else

{

 
    $imgfile = $_POST['imgfile'];

    //Duplicate it. I hope this works!

    $imgfile2 = $imgfile;

    //End Dupe.

    $title = $_POST['title'];

    $des = $_POST['des'];

    $cat = $_POST['cat'];

    $catrep = $_POST['catrep'];

    $comments = $_POST['comments'];

 
    $now = date("F d, Y");

 
 
 
    /* SUBMITTED INFORMATION - use what you need

     * temporary filename (pointer): $imgfile

     * original filename           : $imgfile_name

     * size of uploaded file       : $imgfile_size

     * mime-type of uploaded file  : $imgfile_type

     */

 
     $imgfile_name = $_FILES['imgfile']['name'];

     $imgfile2_name = $_FILES['imgfile']['name'];

     $imgfile_size = $_FILES['imgfile']['size'];

 
     /*== upload directory where the file will be stored

          relative to where script is run ==*/

 
    $uploaddir = "../imgstore/";

 
    /*== get file extension (fn at top of script) ==*/

    /*== checks to see if image file, if not do not allow upload ==*/

    $pext = getFileExtension($imgfile_name);

    $pext = strtolower($pext);

    if (($pext != "jpg")  && ($pext != "jpeg"))

    {

        print "<h1>ERROR</h1>Image Extension Unknown.<br>";

        print "<p>Please upload only a JPEG image with the extension .jpg or .jpeg ONLY<br><br>";

        print "The file you uploaded had the following extension: $pext</p>\n";

 
        /*== delete uploaded file ==*/

        unlink($imgfile);

        unlink($imgfile2);

        exit();

    }

 
    $thisimgrnd = rand(100, 999);

 
    $imgfile_name = $thisimgrnd."_".$imgfile_name;

    $imgfile2_name = $thisimgrnd."_thumb_".$imgfile2_name;

 
    //-- RE-SIZING UPLOADED IMAGE - 100x70

 
    /*== only resize if the image is larger than 100 x 70 ==*/

    $imgsize2 = GetImageSize($imgfile2);

 
    /*== check size  0=width, 1=height ==*/

    if (($imgsize2[0] > 100) || ($imgsize2[1] > 70))

    {

        /*== temp image file -- use "tempnam()" to generate the temp

             file name. This is done so if multiple people access the

            script at once they won't ruin each other's temp file ==*/

        $tmpimg2 = tempnam("/tmp/", "MKUP");

 
        /*== RESIZE PROCESS

             1. decompress jpeg image to pnm file (a raw image type)

             2. scale pnm image

             3. compress pnm file to jpeg image

        ==*/

 
        /*== Step 1: djpeg decompresses jpeg to pnm ==*/

        system("djpeg $imgfile2 >$tmpimg2");

 
 
        /*== Steps 2&3: scale image using pnmscale and then

             pipe into cjpeg to output jpeg file ==*/

        system("pnmscale -xy 100 70 $tmpimg2 | cjpeg -smoo 10 -qual 50 >$imgfile2");

 
        /*== remove temp image ==*/

        unlink($tmpimg2);

 
    }

 
    /*== setup final file location and name ==*/

    /*== change spaces to underscores in filename  ==*/

    $final_filename2 = str_replace(" ", "_", $imgfile2_name);

    $newfile2 = $uploaddir . "/$final_filename2";

 
    /*== delete the temporary uploaded file ==*/

    unlink($imgfile2);

 
    if (is_uploaded_file($imgfile2))

    {

 
       /*== move file to proper directory ==*/

       if (!copy($imgfile2,"$newfile2"))

       {

          /*== if an error occurs the file could not

               be written, read or possibly does not exist ==*/

          print "Error Uploading File.";

          exit();

       }

     }

 
    //print("<img src=\"$final_filename2\">");

 
 
 
 
 
    //-- RE-SIZING UPLOADED IMAGE - 660x1000

 
    /*== only resize if the image is larger than 660 x 1000 ==*/

    $imgsize = GetImageSize($imgfile);

 
    /*== check size  0=width, 1=height ==*/

    if (($imgsize[0] > 660) || ($imgsize[1] > 1000))

    {

        /*== temp image file -- use "tempnam()" to generate the temp

             file name. This is done so if multiple people access the

            script at once they won't ruin each other's temp file ==*/

        $tmpimg = tempnam("/tmp", "MKUP");

 
        /*== RESIZE PROCESS

             1. decompress jpeg image to pnm file (a raw image type)

             2. scale pnm image

             3. compress pnm file to jpeg image

        ==*/

 
        /*== Step 1: djpeg decompresses jpeg to pnm ==*/

        system("djpeg $imgfile >$tmpimg");

 
 
        /*== Steps 2&3: scale image using pnmscale and then

             pipe into cjpeg to output jpeg file ==*/

        system("pnmscale -xy 660 1000 $tmpimg | cjpeg -smoo 10 -qual 50 >$imgfile");

 
        /*== remove temp image ==*/

        unlink($tmpimg);

 
    }

 
    /*== setup final file location and name ==*/

    /*== change spaces to underscores in filename  ==*/

    $final_filename = str_replace(" ", "_", $imgfile_name);

    $newfile = $uploaddir . "/$final_filename";

 
    /*== delete the temporary uploaded file ==*/

    unlink($imgfile);

 
 
    //print("<img src=\"$final_filename\">");

 
 
    /*== do extra security check to prevent malicious abuse==*/

    if (is_uploaded_file($imgfile))

    {

 
       /*== move file to proper directory ==*/

       if (!copy($imgfile,"$newfile"))

       {

          /*== if an error occurs the file could not

               be written, read or possibly does not exist ==*/

          print "Error Uploading File.";

          exit();

       }

     }

 
    /*== DO WHATEVER ELSE YOU WANT

         SUCH AS INSERT DATA INTO A DATABASE  ==*/

 
 
 
 
 
    //Add to db.

 
    

?>

<html>

<head>

<title>Upload New Picture</title>

</head>

<body>

<h1>Photo successfully uploaded. (hopefully)</h1>

 
<img src="../imgstore/<?php echo($final_filename2); ?>" />

<br><br>

<a href="main.php">Menu</a> | <a href="newimg.php">UPLOAD ANOTHER?</a>

 
 
<br><br><br>

 
(c) 2007 ***.

 
</body>

</html>

<?php

}

?>

It's not pretty... it's not secure... it's not FINISHED. So before posting anything off-topic of what I want fixed, consider that

Thanks.

I actually have little idea of what I'm doing...

So um, be nice

Thanks! Help appreciated. Rep +
.chulium.

lfhost · 03-04-2007, 03:58 PM

Code:

$imgfile = $_POST['imgfile'];

should be

Code:

$imgfile = $_FILES['imgfile']['name'];

or

Code:

$imgfile = $_FILES['imgfile']['tmp_name'];

mholt · 03-04-2007, 04:44 PM

Nope... that just made 2 more errors (both methods):

Code:

Warning: getimagesize(test.jpg) [function.getimagesize]: failed to open stream: No such file or directory in /home/***/public_html/imgadmin/newimg.php on line 138

Warning: unlink(test.jpg) [function.unlink]: No such file or directory in /home/***/public_html/imgadmin/newimg.php on line 173

Warning: getimagesize(test.jpg) [function.getimagesize]: failed to open stream: No such file or directory in /home/***/public_html/imgadmin/newimg.php on line 197

Warning: unlink(test.jpg) [function.unlink]: No such file or directory in /home/***/public_html/imgadmin/newimg.php on line 232

I do want to point out though that I'm duplicating the image variable ($imgfile2 and $imgfile) just on submission so I can turn one into a thumbnail, and just trim the other one down to size.

mholt · 03-05-2007, 04:43 PM

...I still need help with this. Please?

Suppose I offered a $10 USD PayPal reward when this works right?

**labrocca** · 03-05-2007, 06:41 PM

Is your file even uploading? I prefer to use move_uploaded_file() and then make any changes to the file. Safe_mode restrictions normally prevent you from working on a file in the original tmp directory.

mholt · 03-05-2007, 07:55 PM

It's not uploading

I put in a quick error checker and changed the is_uploaded_file() to move_uploaded_file() and added the proper arguments for file and destination.

I get an error now that it won't upload.... yet I'm not 100% sure why. Can anybody maybe write a quick, clean upload script as the ones I see on Google are either too simple, too complicated, or all contradict each other in methodology.

**labrocca** · 03-05-2007, 10:59 PM

Use hotscripts and find something free. Lots of things out there if you look hard enough. If you want a fairly full featured upload script try celerondude.com's script.

cef · 03-06-2007, 12:21 AM

The php manual has a very detailed section on file uploads, including some sample code which has always worked for me and serves as the foundation for numerous image upload and manipulation scripts I've written: http://us3.php.net/manual/en/features.file-upload.php

IMPORTANT: read the user comments at the bottom of the page. Lots of suggestions for things to look at if your upload still fails (various php.ini settings, permissions, etc.)

mholt · 03-06-2007, 04:31 PM

Thanks both.

labrocca: I am using a simple, self-programmed gallery script for my photography site. Thanks for the suggestion, though.

cef: I'll check it out; danke.

If I still need help I'll update this thread.

03-03-2007, 01:01 PM	#1 (permalink)
mholt DNOA Member Join Date: May 2004 Location: Utah Posts: 5,041 18.01 NP$ (Donate)	PHP uploading problems Hello... I have an upload script that I found online (I've only worked with uploads once in my life, and it didn't involve image resizing): PHP Code: /== only resize if the image is larger than 660 x 1000 ==/ $imgsize = GetImageSize($imgfile); /== check size 0=width, 1=height ==/ if (($imgsize[0] > 660) \|\| ($imgsize[1] > 1000)) { /== temp image file -- use "tempnam()" to generate the temp file name. This is done so if multiple people access the script at once they won't ruin each other's temp file ==/ $tmpimg = tempnam("/tmp", "MKUP"); /== RESIZE PROCESS 1. decompress jpeg image to pnm file (a raw image type) 2. scale pnm image 3. compress pnm file to jpeg image ==/ /== Step 1: djpeg decompresses jpeg to pnm ==/ system("djpeg $imgfile >$tmpimg"); /== Steps 2&3: scale image using pnmscale and then pipe into cjpeg to output jpeg file ==/ system("pnmscale -xy 660 1000 $tmpimg \| cjpeg -smoo 10 -qual 50 >$imgfile"); /== remove temp image ==/ unlink($tmpimg); } /== setup final file location and name ==/ /== change spaces to underscores in filename ==/ $final_filename = str_replace(" ", "_", $imgfile_name); $newfile = $uploaddir . "/$final_filename"; /== delete the temporary uploaded file ==/ unlink($imgfile); //print("<img src=\"$final_filename\">"); /== do extra security check to prevent malicious abuse==/ if (is_uploaded_file($imgfile)) { /== move file to proper directory ==/ if (!copy($imgfile,"$newfile")) { /== if an error occurs the file could not be written, read or possibly does not exist ==/ print "Error Uploading File."; exit(); } } The error comes on the line with the unlink($tmpimg) function at the end of the resizing where it deletes the temporary file. It says there's no such file or directory, yet there's no other errors given out. Any help appreciated Thanks. .chulium. (I didn't include ALL of the code, like the form, etc, but everything else is working fine. I've spent hours trying to debug this script... trust me on the previous code: it's good.) __________________ codeboards A high-quality community of programmers -- Join today and post! We want new members!

03-03-2007, 01:10 PM	#3 (permalink)
iNod Eating Pie Join Date: Nov 2004 Location: Canada Posts: 2,289 126.05 NP$ (Donate)	You don't need to delete the tmp file. The server will do it for you and PHP cannot access the /tmp folder. Does it work otherwise? - Steve __________________ I feel old.

03-03-2007, 01:15 PM	#4 (permalink)
mholt DNOA Member Join Date: May 2004 Location: Utah Posts: 5,041 18.01 NP$ (Donate)	No, the upload doesn't work at all... I CHMOD'ed everything to 777 (well, everything being the upload directory I made)... __________________ codeboards A high-quality community of programmers -- Join today and post! We want new members!

03-04-2007, 11:52 AM	#6 (permalink)
mholt DNOA Member Join Date: May 2004 Location: Utah Posts: 5,041 18.01 NP$ (Donate)	I did of course Any other ideas? :-/ __________________ codeboards A high-quality community of programmers -- Join today and post! We want new members!

03-04-2007, 01:42 PM	#7 (permalink)
lfhost NamePros Member Join Date: Jan 2005 Posts: 112 0.00 NP$ (Donate)	1, where are you defining the $_FILE ? all I see is $imgfile 2, does your server support Imagemajik/system() commands? 3, is $uploaddir set anywhere and to the same folder you have chmodd? 4, Have you tried dumping what is uploaded i.e. PHP Code: `print_r($_FILES);` 5, You may want to show your form to make sure you are allowing the enctype upload. __________________ Thanks Paul 1\|2\|3\|4\|5\|6\|7\|8\|9\|10\|11\|12\|13

Forum Moderator

Forum Moderator

03-03-2007, 01:08 PM	#2 (permalink)
Dan Buy my domains. Join Date: Feb 2006 Posts: 2,801 56.00 NP$ (Donate)	You probably don't need to have that line.. it's a temp file and will probably be deleted anyways.

03-04-2007, 11:39 AM	#5 (permalink)
smilgy NamePros Regular Join Date: Jan 2007 Posts: 253 29.20 NP$ (Donate)	did u put <php? in front of the script and ?> at the end?

03-04-2007, 03:44 PM	#8 (permalink)
mholt DNOA Member Join Date: May 2004 Location: Utah Posts: 5,041 18.01 NP$ (Donate)	This might be easier... here's my whole code: PHP Code: <?php include("functions.php"); function getFileExtension($str) { $i = strrpos($str,"."); if (!$i) { return ""; } $l = strlen($str) - $i; $ext = substr($str,$i+1,$l); return $ext; } if (!$_GET['go']) { ?> <html> <head> <title>Upload New Picture</title> </head> <body> <h1>Upload New Photograph</h1> (Max file size: 2.0 MB)<br><br> <form method="post" action="newimg.php?go=true" enctype="multipart/form-data" id="mf" name="mf"> <input type="hidden" name="MAX_FILE_SIZE" value="2000000"> Image: <input type="file" name="imgfile"> <br><br> Caption: <input type="text" size="40" maxlength="100" name="title"> <br><br> Description: <textarea cols="40" rows="5" name="des"></textarea> <br><br> Category: <select size="1" name="catid"> <option value="" SELECTED></option> <?php $q = mysql_query("SELECT * FROM categories ORDER BY title ASC"); $i = 0; while ($r = mysql_fetch_array($q)) { $title = stripslashes($r['title']); $id = $r['id']; ?> <option value="<?php echo($id); ?>"><?php echo($title); ?></option> <?php } ?> </select> <br><br> Make Category Thumbnail? <select size="1" name="catrep"> <option value="No" SELECTED>No</option> <option value="Yes">Yes</option> </select> <br><br> Comments: <select size="1" name="comments"> <option value="On" SELECTED>On</option> <option value="Off">Off</option> </select> <br><br> <input type="submit" value="Upload Image" id="sbt" onClick="this.disabled=true;return true;">   <a href="main.php">Menu</a> </form> <br><br><br> (c) 2007 ***. </body> </html> <?php } else { $imgfile = $_POST['imgfile']; //Duplicate it. I hope this works! $imgfile2 = $imgfile; //End Dupe. $title = $_POST['title']; $des = $_POST['des']; $cat = $_POST['cat']; $catrep = $_POST['catrep']; $comments = $_POST['comments']; $now = date("F d, Y"); / SUBMITTED INFORMATION - use what you need * temporary filename (pointer): $imgfile * original filename : $imgfile_name * size of uploaded file : $imgfile_size * mime-type of uploaded file : $imgfile_type / $imgfile_name = $_FILES['imgfile']['name']; $imgfile2_name = $_FILES['imgfile']['name']; $imgfile_size = $_FILES['imgfile']['size']; /== upload directory where the file will be stored relative to where script is run ==/ $uploaddir = "../imgstore/"; /== get file extension (fn at top of script) ==/ /== checks to see if image file, if not do not allow upload ==/ $pext = getFileExtension($imgfile_name); $pext = strtolower($pext); if (($pext != "jpg") && ($pext != "jpeg")) { print "<h1>ERROR</h1>Image Extension Unknown.<br>"; print "<p>Please upload only a JPEG image with the extension .jpg or .jpeg ONLY<br><br>"; print "The file you uploaded had the following extension: $pext</p>\n"; /== delete uploaded file ==/ unlink($imgfile); unlink($imgfile2); exit(); } $thisimgrnd = rand(100, 999); $imgfile_name = $thisimgrnd."_".$imgfile_name; $imgfile2_name = $thisimgrnd."_thumb_".$imgfile2_name; //-- RE-SIZING UPLOADED IMAGE - 100x70 /== only resize if the image is larger than 100 x 70 ==/ $imgsize2 = GetImageSize($imgfile2); /== check size 0=width, 1=height ==/ if (($imgsize2[0] > 100) \|\| ($imgsize2[1] > 70)) { /== temp image file -- use "tempnam()" to generate the temp file name. This is done so if multiple people access the script at once they won't ruin each other's temp file ==/ $tmpimg2 = tempnam("/tmp/", "MKUP"); /== RESIZE PROCESS 1. decompress jpeg image to pnm file (a raw image type) 2. scale pnm image 3. compress pnm file to jpeg image ==/ /== Step 1: djpeg decompresses jpeg to pnm ==/ system("djpeg $imgfile2 >$tmpimg2"); /== Steps 2&3: scale image using pnmscale and then pipe into cjpeg to output jpeg file ==/ system("pnmscale -xy 100 70 $tmpimg2 \| cjpeg -smoo 10 -qual 50 >$imgfile2"); /== remove temp image ==/ unlink($tmpimg2); } /== setup final file location and name ==/ /== change spaces to underscores in filename ==/ $final_filename2 = str_replace(" ", "_", $imgfile2_name); $newfile2 = $uploaddir . "/$final_filename2"; /== delete the temporary uploaded file ==/ unlink($imgfile2); if (is_uploaded_file($imgfile2)) { /== move file to proper directory ==/ if (!copy($imgfile2,"$newfile2")) { /== if an error occurs the file could not be written, read or possibly does not exist ==/ print "Error Uploading File."; exit(); } } //print("<img src=\"$final_filename2\">"); //-- RE-SIZING UPLOADED IMAGE - 660x1000 /== only resize if the image is larger than 660 x 1000 ==/ $imgsize = GetImageSize($imgfile); /== check size 0=width, 1=height ==/ if (($imgsize[0] > 660) \|\| ($imgsize[1] > 1000)) { /== temp image file -- use "tempnam()" to generate the temp file name. This is done so if multiple people access the script at once they won't ruin each other's temp file ==/ $tmpimg = tempnam("/tmp", "MKUP"); /== RESIZE PROCESS 1. decompress jpeg image to pnm file (a raw image type) 2. scale pnm image 3. compress pnm file to jpeg image ==/ /== Step 1: djpeg decompresses jpeg to pnm ==/ system("djpeg $imgfile >$tmpimg"); /== Steps 2&3: scale image using pnmscale and then pipe into cjpeg to output jpeg file ==/ system("pnmscale -xy 660 1000 $tmpimg \| cjpeg -smoo 10 -qual 50 >$imgfile"); /== remove temp image ==/ unlink($tmpimg); } /== setup final file location and name ==/ /== change spaces to underscores in filename ==/ $final_filename = str_replace(" ", "_", $imgfile_name); $newfile = $uploaddir . "/$final_filename"; /== delete the temporary uploaded file ==/ unlink($imgfile); //print("<img src=\"$final_filename\">"); /== do extra security check to prevent malicious abuse==/ if (is_uploaded_file($imgfile)) { /== move file to proper directory ==/ if (!copy($imgfile,"$newfile")) { /== if an error occurs the file could not be written, read or possibly does not exist ==/ print "Error Uploading File."; exit(); } } /== DO WHATEVER ELSE YOU WANT SUCH AS INSERT DATA INTO A DATABASE ==/ //Add to db. ?> <html> <head> <title>Upload New Picture</title> </head> <body> <h1>Photo successfully uploaded. (hopefully)</h1> <img src="../imgstore/<?php echo($final_filename2); ?>" /> <br><br> <a href="main.php">Menu</a> \| <a href="newimg.php">UPLOAD ANOTHER?</a> <br><br><br> (c) 2007 . </body> </html> <?php } ?> It's not pretty... it's not secure... it's not FINISHED. So before posting anything off-topic of what I want fixed, consider that Thanks. I actually have little idea of what I'm doing... So um, be nice Thanks! Help appreciated. Rep + .chulium. __________________ code**boards A high-quality community of programmers -- Join today and post! We want new members!

03-04-2007, 03:58 PM	#9 (permalink)
lfhost NamePros Member Join Date: Jan 2005 Posts: 112 0.00 NP$ (Donate)	Code: $imgfile = $_POST['imgfile']; should be Code: $imgfile = $_FILES['imgfile']['name']; or Code: $imgfile = $_FILES['imgfile']['tmp_name']; __________________ Thanks Paul 1\|2\|3\|4\|5\|6\|7\|8\|9\|10\|11\|12\|13

03-05-2007, 04:43 PM	#11 (permalink)
mholt DNOA Member Join Date: May 2004 Location: Utah Posts: 5,041 18.01 NP$ (Donate)	...I still need help with this. Please? Suppose I offered a $10 USD PayPal reward when this works right? __________________ codeboards A high-quality community of programmers -- Join today and post! We want new members!

03-05-2007, 06:41 PM	#12 (permalink)
labrocca Recovering Jerk Forum Moderator Join Date: Aug 2004 Location: Las Vegas Posts: 5,499 1,196.64 NP$ (Donate)	Is your file even uploading? I prefer to use move_uploaded_file() and then make any changes to the file. Safe_mode restrictions normally prevent you from working on a file in the original tmp directory. __________________ Proxy Filter SEO Tag Cloud Domain Name Generator Debate Forums Free Online Sudoku \| My vBum Blog

03-05-2007, 07:55 PM	#13 (permalink)
mholt DNOA Member Join Date: May 2004 Location: Utah Posts: 5,041 18.01 NP$ (Donate)	It's not uploading I put in a quick error checker and changed the is_uploaded_file() to move_uploaded_file() and added the proper arguments for file and destination. I get an error now that it won't upload.... yet I'm not 100% sure why. Can anybody maybe write a quick, clean upload script as the ones I see on Google are either too simple, too complicated, or all contradict each other in methodology. __________________ codeboards A high-quality community of programmers -- Join today and post! We want new members!

03-05-2007, 10:59 PM	#14 (permalink)
labrocca Recovering Jerk Forum Moderator Join Date: Aug 2004 Location: Las Vegas Posts: 5,499 1,196.64 NP$ (Donate)	Use hotscripts and find something free. Lots of things out there if you look hard enough. If you want a fairly full featured upload script try celerondude.com's script. __________________ Proxy Filter SEO Tag Cloud Domain Name Generator Debate Forums Free Online Sudoku \| My vBum Blog

03-06-2007, 12:21 AM	#15 (permalink)
cef NamePros Regular Join Date: May 2004 Location: NYC Posts: 236 76.50 NP$ (Donate)	The php manual has a very detailed section on file uploads, including some sample code which has always worked for me and serves as the foundation for numerous image upload and manipulation scripts I've written: http://us3.php.net/manual/en/features.file-upload.php IMPORTANT: read the user comments at the bottom of the page. Lots of suggestions for things to look at if your upload still fails (various php.ini settings, permissions, etc.)

03-06-2007, 04:31 PM	#16 (permalink)
mholt DNOA Member Join Date: May 2004 Location: Utah Posts: 5,041 18.01 NP$ (Donate)	Thanks both. labrocca: I am using a simple, self-programmed gallery script for my photography site. Thanks for the suggestion, though. cef: I'll check it out; danke. If I still need help I'll update this thread. __________________ codeboards A high-quality community of programmers -- Join today and post! We want new members!

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)