Whats wrong with this? (searching database for specific id)

killaklown · 02-23-2007, 05:16 PM

This is the code which im having problems with (its not all the code, so i am not missing the <?php, or a })

Code:

    $sql_query = "SELECT * FROM links WHERE id='$id'";
    //store the SQL query in the result variable
    $result = mysql_query($sql_query);

    if(mysql_num_rows($result))
    {
    //output as long as there are still available fields
    while($row = mysql_fetch_array($result))
    {
        $title = $row["title"];
        $url = $row["url"];
        $id = $row["id"];
        $status = $row["status"];
		$email = $row["email"];
   }

Im trying to get it to let you edit the information in the 'links' part of the database. The page before has this code:

Code:

<a href=\"editlink.php?id=$id\">Edit</a>

The id is right and everything, but the page always shows it as blank. I had it working a long time ago, then kind of forgot about it and now it doesnt work.

shreder · 02-23-2007, 06:29 PM

Try this:

<a href=\"editlink.php?id=<?= $id ?>\">Edit</a>

Slewey · 02-23-2007, 11:40 PM

aren't you forgetting to get the id from the link?
try this query

PHP Code:

  SELECT * FROM links WHERE id='".$_GET['id']."'";

or you shloud define your variable id before executing the query

PHP Code:

  $id = $_GET['id'];

 
    $sql_query = "SELECT * FROM links WHERE id='$id'";

    //store the SQL query in the result variable

    $result = mysql_query($sql_query);

 
    if(mysql_num_rows($result))

    {

    //output as long as there are still available fields

    while($row = mysql_fetch_array($result))

    {

        $title = $row["title"];

        $url = $row["url"];

        $id = $row["id"];

        $status = $row["status"];

        $email = $row["email"];

   }

killaklown · 02-24-2007, 08:57 AM

Quote:

Originally Posted by Slewey

aren't you forgetting to get the id from the link?
try this query

PHP Code:

  SELECT * FROM links WHERE id='".$_GET['id']."'";

Haha, thanks slewey, i knew it was something to do with that line.

Rep added. I see the rep also got you another green bar

Matthew. · 02-24-2007, 09:20 AM

Please remember to validate and secure your inputs folks, killaklown remember that is extremely insecure as it is right now

Just my piece of advice although the problem is solved

Matt

Slewey · 02-25-2007, 10:52 AM

Quote:

Originally Posted by killaklown

Haha, thanks slewey, i knew it was something to do with that line.

Rep added. I see the rep also got you another green bar

np

02-23-2007, 05:16 PM	#1 (permalink)
killaklown Senior Member Join Date: Oct 2003 Location: Winnipeg, Canada Posts: 3,472 5.31 NP$ (Donate)	Whats wrong with this? (searching database for specific id) This is the code which im having problems with (its not all the code, so i am not missing the <?php, or a }) Code: $sql_query = "SELECT * FROM links WHERE id='$id'"; //store the SQL query in the result variable $result = mysql_query($sql_query); if(mysql_num_rows($result)) { //output as long as there are still available fields while($row = mysql_fetch_array($result)) { $title = $row["title"]; $url = $row["url"]; $id = $row["id"]; $status = $row["status"]; $email = $row["email"]; } Im trying to get it to let you edit the information in the 'links' part of the database. The page before has this code: Code: <a href=\"editlink.php?id=$id\">Edit</a> The id is right and everything, but the page always shows it as blank. I had it working a long time ago, then kind of forgot about it and now it doesnt work.

02-23-2007, 06:29 PM	#2 (permalink)
shreder NamePros Regular Join Date: Mar 2006 Posts: 779 5.00 NP$ (Donate)	Try this: <a href=\"editlink.php?id=<?= $id ?>\">Edit</a> __________________ EKED.COM BDPU.COM FFHF.COM BXNN.COM SFUZ.COM OOHH.NET EOEI.COM NSTO.COM SPMQ.COM CODV.COM - Pm Offers *"What doesn't kill you only makes you stronger..."*

02-23-2007, 11:40 PM	#3 (permalink)
Slewey NamePros Regular Join Date: Apr 2004 Location: NL Posts: 827 316.85 NP$ (Donate)	aren't you forgetting to get the id from the link? try this query PHP Code: `SELECT * FROM links WHERE id='".$_GET['id']."'";` or you shloud define your variable id before executing the query PHP Code: $id = $_GET['id']; $sql_query = "SELECT * FROM links WHERE id='$id'"; //store the SQL query in the result variable $result = mysql_query($sql_query); if(mysql_num_rows($result)) { //output as long as there are still available fields while($row = mysql_fetch_array($result)) { $title = $row["title"]; $url = $row["url"]; $id = $row["id"]; $status = $row["status"]; $email = $row["email"]; } __________________ xmpv.com \| nuwp.com \| frot.info \|

02-24-2007, 09:20 AM	#5 (permalink)
Matthew. Stud Sausage Join Date: Dec 2006 Location: England Posts: 1,546 34.41 NP$ (Donate)	Please remember to validate and secure your inputs folks, killaklown remember that is extremely insecure as it is right now Just my piece of advice although the problem is solved Matt __________________ My NamePros Tools (firefox plugin, google gadget etc)

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)