Where is the mistake in here?

baris22 · 02-16-2007, 05:08 PM

Hello all,

I could not solve this problem. There is a mistake in here but i do not know where.

Please help

PHP Code:

   
{

    $desc = str_replace("[", "\r\n", $_REQUEST['description']);

    $arrayOflinks = explode(";", $_REQUEST['links']);

 
    // Get Extension of first extry

    $extPos = strrpos($arrayOflinks[0], ".");

    if ($extPos !== false)

    {

        $ext = substr($arrayOflinks[0], $extPos+1);

        $extL = strtolower($ext);

        if (!strcasecmp($extL, "bmp") || !strcasecmp($extL, "jpg") || !strcasecmp($extL, "gif"))

        {

            $imageTag = "<img src='".$arrayOflinks[0]."' border='0'>";

            $arrayOflinks[0]=$imageTag;

        }

    }

    $link = implode("<br>", $arrayOflinks);

 
 
    $query = "insert into articles (`id`, `type`, `title`, `description`, `links`) values('0', '".$_REQUEST['type']."','".$_REQUEST['title']."','".$desc."','".$link."')";

    print $query;

    mysql_query($query);

    exit();

}

NewYorkBum · 02-16-2007, 05:13 PM

could you post the error you getting as well ?

baris22 · 02-16-2007, 05:20 PM

There is no error. it is just not recording to the database.

If I do like this it works

PHP Code:

   
{ 

    $desc = str_replace("[", "\r\n", $_REQUEST['description']); 

    $link = str_replace(";", "<br>", $_REQUEST['links']);

 
   

    $query = "insert into articles (`id`, `type`, `title`, `description`, `links`) values('0', '".$_REQUEST['type']."','".$_REQUEST['title']."','".$desc."','".$link."')"; 

    print $query; 

    mysql_query($query); 

    exit(); 

}

silentwind · 02-16-2007, 07:22 PM

Did you use auto-increment and primary key or unique on `id` field? if yes, that would be the problem.
Try using these :

PHP Code:

  $query = "insert into articles (`type`, `title`, `description`, `links`) values('".$_REQUEST['type']."','".$_REQUEST['title']."','".$desc."','".$link."')";

Matthew. · 02-17-2007, 01:57 AM

edit: Nevermind, re-read OP.

tm · 02-17-2007, 02:26 AM

change

PHP Code:

   mysql_query($query);

to

PHP Code:

   mysql_query($query) or die(mysql_error());

So we can see the error if there is one.

NetworkTown.Net · 02-17-2007, 05:29 AM

Im sure mysql is case sensitive

try changing "insert into" to "INSERT INTO"

sdsinc · 02-17-2007, 05:51 AM

Quote:

Originally Posted by NetworkTown.Net

Im sure mysql is case sensitive

try changing "insert into" to "INSERT INTO"

The SQL commands are not case-sensitive

Also the INTO keyword is not needed here, remove it:

Code:

$query = "insert articles (`id`, `type`, `title`, `description`, `links`) values('0', '".$_REQUEST['type']."','".$_REQUEST['title']."','".$desc."','".$link."')";

SELECT INTO is used when you want to perform a multiple insert based on another table or query.

Is ID an auto-incremented field or primary key ? If it's an auto-incremented value remove it from your insert statement.

Finally you are performing inserts based on $_REQUEST variables which is dangerous.

1. You need to check the input values, otherwise people can manipulate them and enter anything, including values that will crash your script.
2. You need to check if there are any single quotes (') that need escaping. Have a look at mysql_real_escape_string: http://php.net/mysql_real_escape_string. Again your script could crash if special characters are not properly handled.

My advice would be: at the beginning of your script check the $_REQUEST values and assign them to variables. Then check if they are not empty, have the expected format etc (regular expressions are very helpful for this).

Barrucadu · 02-17-2007, 05:51 AM

Quote:

Originally Posted by NetworkTown.Net

Im sure mysql is case sensitive

try changing "insert into" to "INSERT INTO"

The case of the commands dosn't matter, its more of a standard to use upper case commands though.

Yes, do as tm said and get the error with mysql_error(); and tell us what it is.

Dan · 02-17-2007, 06:04 AM

Quote:

Code:

    $query = "insert into articles (`id`, `type`, `title`, `description`, `links`) values('0', '".$_REQUEST['type']."','".$_REQUEST['title']."','".$desc."','".$link."')";
    print $query;

Just run the query in phpMyAdmin and it should tell you exactly what the problem is.

DylanButler · 02-17-2007, 10:26 AM

Quote:

Originally Posted by NetworkTown.Net

Im sure mysql is case sensitive

try changing "insert into" to "INSERT INTO"

Can I put this in my sig?

baris22 · 02-17-2007, 11:58 AM

Thanks for help. But the problem is in here. If i do not write this, it works fine but if i write this it does not work.

I do not have a chance to check what is wrong. It is not possible. This page is getting called by a windows application. If the code is wrong , I do not get any error message. If the code is right, it is recording to the database.

Thanks all

PHP Code:

   
$arrayOflinks = explode(";", $_REQUEST['links']); 

 
    // Get Extension of first extry 

    $extPos = strrpos($arrayOflinks[0], "."); 

    if ($extPos !== false) 

    { 

        $ext = substr($arrayOflinks[0], $extPos+1); 

        $extL = strtolower($ext); 

        if (!strcasecmp($extL, "bmp") || !strcasecmp($extL, "jpg") || !strcasecmp($extL, "gif")) 

        { 

            $imageTag = "<img src='".$arrayOflinks[0]."' border='0'>"; 

            $arrayOflinks[0]=$imageTag; 

        } 

    } 

    $link = implode("<br>", $arrayOflinks);

cef · 02-17-2007, 05:03 PM

try changing this

PHP Code:

  $link = implode("<br>", $arrayOflinks);

to this

PHP Code:

  $link = mysql_real_escape_string(implode("<br>", $arrayOflinks));

baris22 · 02-17-2007, 07:16 PM

Quote:

Originally Posted by cef

try changing this

PHP Code:

  $link = implode("<br>", $arrayOflinks);

to this

PHP Code:

  $link = mysql_real_escape_string(implode("<br>", $arrayOflinks));

Wawwwwww. Thank you very much man. It worked.
I was trying to sort this out for 3 days.

Thanks again.

NetworkTown.Net · 02-18-2007, 08:41 AM

Quote:

Originally Posted by DylanButler

Can I put this in my sig?

:@ Ok i made a mistake no need to take it that far.

02-16-2007, 05:08 PM	#1 (permalink)
baris22 NamePros Member Join Date: Jan 2007 Posts: 68 0.00 NP$ (Donate)	Where is the mistake in here? Hello all, I could not solve this problem. There is a mistake in here but i do not know where. Please help PHP Code: { $desc = str_replace("[", "\r\n", $_REQUEST['description']); $arrayOflinks = explode(";", $_REQUEST['links']); // Get Extension of first extry $extPos = strrpos($arrayOflinks[0], "."); if ($extPos !== false) { $ext = substr($arrayOflinks[0], $extPos+1); $extL = strtolower($ext); if (!strcasecmp($extL, "bmp") \|\| !strcasecmp($extL, "jpg") \|\| !strcasecmp($extL, "gif")) { $imageTag = "<img src='".$arrayOflinks[0]."' border='0'>"; $arrayOflinks[0]=$imageTag; } } $link = implode("<br>", $arrayOflinks); $query = "insert into articles (`id`, `type`, `title`, `description`, `links`) values('0', '".$_REQUEST['type']."','".$_REQUEST['title']."','".$desc."','".$link."')"; print $query; mysql_query($query); exit(); }

02-16-2007, 05:20 PM	#3 (permalink)
baris22 NamePros Member Join Date: Jan 2007 Posts: 68 0.00 NP$ (Donate)	There is no error. it is just not recording to the database. If I do like this it works PHP Code: { $desc = str_replace("[", "\r\n", $_REQUEST['description']); $link = str_replace(";", "<br>", $_REQUEST['links']); $query = "insert into articles (`id`, `type`, `title`, `description`, `links`) values('0', '".$_REQUEST['type']."','".$_REQUEST['title']."','".$desc."','".$link."')"; print $query; mysql_query($query); exit(); }

02-16-2007, 07:22 PM	#4 (permalink)
silentwind NamePros Member Join Date: Feb 2007 Location: Surabaya - Indonesia Posts: 27 0.00 NP$ (Donate)	Did you use auto-increment and primary key or unique on `id` field? if yes, that would be the problem. Try using these : PHP Code: $query = "insert into articles (`type`, `title`, `description`, `links`) values('".$_REQUEST['type']."','".$_REQUEST['title']."','".$desc."','".$link."')";

02-17-2007, 01:57 AM	#5 (permalink)
Matthew. Stud Sausage Join Date: Dec 2006 Location: England Posts: 1,546 34.41 NP$ (Donate)	edit: Nevermind, re-read OP. __________________ My NamePros Tools (firefox plugin, google gadget etc) Last edited by Matthew.; 02-17-2007 at 02:02 AM.

02-17-2007, 02:26 AM	#6 (permalink)
tm Senior Member Join Date: Nov 2005 Location: on a oil rig just off Ireland Posts: 1,409 374.65 NP$ (Donate)	change PHP Code: `mysql_query($query);` to PHP Code: `mysql_query($query) or die(mysql_error());` So we can see the error if there is one. __________________ You design in photoshop, I code into valid XHTML/CSS. Professional PSD, PNG or HTML to tableless XHTML/CSS designs. For more info, send me a PM.

02-16-2007, 05:13 PM	#2 (permalink)
NewYorkBum NamePros Regular Join Date: Jan 2007 Posts: 241 30.50 NP$ (Donate)	could you post the error you getting as well ?

02-17-2007, 05:29 AM	#7 (permalink)
NetworkTown.Net Account Closed Join Date: Oct 2005 Location: United Kingdom Posts: 1,554 55.39 NP$ (Donate)	Im sure mysql is case sensitive try changing "insert into" to "INSERT INTO"

02-17-2007, 11:58 AM	#12 (permalink)
baris22 NamePros Member Join Date: Jan 2007 Posts: 68 0.00 NP$ (Donate)	Thanks for help. But the problem is in here. If i do not write this, it works fine but if i write this it does not work. I do not have a chance to check what is wrong. It is not possible. This page is getting called by a windows application. If the code is wrong , I do not get any error message. If the code is right, it is recording to the database. Thanks all PHP Code: $arrayOflinks = explode(";", $_REQUEST['links']); // Get Extension of first extry $extPos = strrpos($arrayOflinks[0], "."); if ($extPos !== false) { $ext = substr($arrayOflinks[0], $extPos+1); $extL = strtolower($ext); if (!strcasecmp($extL, "bmp") \|\| !strcasecmp($extL, "jpg") \|\| !strcasecmp($extL, "gif")) { $imageTag = "<img src='".$arrayOflinks[0]."' border='0'>"; $arrayOflinks[0]=$imageTag; } } $link = implode("<br>", $arrayOflinks);

02-17-2007, 05:03 PM	#13 (permalink)
cef NamePros Regular Join Date: May 2004 Location: NYC Posts: 236 76.50 NP$ (Donate)	try changing this PHP Code: `$link = implode("<br>", $arrayOflinks);` to this PHP Code: `$link = mysql_real_escape_string(implode("<br>", $arrayOflinks));`

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)