Query error

unknowngiver · 01-01-2007, 10:16 PM

Hey
i am getting a querry error from this line:

PHP Code:

          $query = "INSERT INTO `mpg` ('id','Manufacturer','Year','Car Name','Miles Per Gallon City',

                  'Miles Per Gallon Freeway','Year Gas Price') 

                  VALUES ('','$manufacturer','$year','$car_name','$mpgc','$mpgf','$year_gas_price')";

        mysql_query($query) or die ("Error, insert query failed");

it gives the "Error,insert query failed" error...and i have 2 questions
1. If there is any visible problem in that piece of code
2. How can i make it show the actual error instead of the die command that i gave it..if i remove that die command..it shows nothing..

AzN · 01-01-2007, 10:20 PM

'$ mpgf' should be '$mpgf

unknowngiver · 01-01-2007, 10:22 PM

hm it is like that..i duno y it added that space when i copy pasted it here :-s

$query = "INSERT INTO mpg ('id','Manufacturer','Year','Car Name','Miles Per Gallon City',
'Miles Per Gallon Freeway','Year Gas Price')
VALUES ('','$manufacturer','$year','$car_name','$mpgc','$ mpgf','$year_gas_price')";
mysql_query($query) or die ("Error, insert query failed");

AzN · 01-01-2007, 10:31 PM

mysql_query("INSERT INTO mpg ('id','Manufacturer','Year','Car Name','Miles Per Gallon City',
'Miles Per Gallon Freeway','Year Gas Price')
VALUES ('','$manufacturer','$year','$car_name','$mpgc','$ mpgf','$year_gas_price'")or die ("Error, insert query failed");

unknowngiver · 01-01-2007, 10:33 PM

isnt it the samething or did u change something from it?

Dan · 01-01-2007, 10:45 PM

It's the same thing.. >__>

Run the query in phpMyAdmin and post the error it gives you. I don't see anything that would just be wrong on its own, unless you can't have spaces in the column titles. The only other thing I see is ' around column names.. shouldn't it be ` or nothing?

If you used spaces between items, it wouldn't put that space in by itself into $mpgf

Matthew. · 01-02-2007, 04:01 AM

Always added error reporting to every query, this will gve you a more descriptive error as Dan said phpmyadmin will.

Run this:

PHP Code:

   $query = "INSERT INTO `mpg` ('id','Manufacturer','Year','Car Name','Miles Per Gallon City',

                  'Miles Per Gallon Freeway','Year Gas Price') 

                  VALUES ('','$manufacturer','$year','$car_name','$mpgc','$  mpgf','$year_gas_price')";

        mysql_query($query) or die ("Error, insert query failed" . mysql_error());

Note the mysql_error() has been added.

The problem is (i suspect) that you are not using backticks for field names, instead you are using '.

Correct query should be:

Code:

INSERT INTO `mpg` (`id`,`Manufacturer`,`Year`,`Car Name`,`Miles Per Gallon City`,
                  `Miles Per Gallon Freeway`,`Year Gas Price`) 
                  VALUES ('','$manufacturer','$year','$car_name','$mpgc','$  mpgf','$year_gas_price')

Peter · 01-02-2007, 04:02 AM

Quote:

Originally Posted by unknowngiver

2. How can i make it show the actual error instead of the die command that i gave it..if i remove that die command..it shows nothing..

Change:-

PHP Code:

  or die ("Error, insert query failed");

To the following:-

PHP Code:

  or die (mysql_errno().' : '.mysql_error());

Best to change it before the site goes into production tho as people can work out how your database is made from the errors.

EDIT Looks like Matthew. just beat me

Matthew. · 01-02-2007, 04:08 AM

Quote:

Originally Posted by filth@flexiwebhost

Change:-

PHP Code:

  or die ("Error, insert query failed");

To the following:-

PHP Code:

  or die (mysql_errno().' : '.mysql_error());

Beat ya

Quote:

Best to change it before the site goes into production tho as people can work out how your database is made from the errors.

Now i've never agreed with that, if someone is in a position where they can executer a query they don't need to know table/field names...You can get those by running a query.

(having said that i normally extend my error logger into the mysql class so they do get hidden)

Redleg · 01-02-2007, 04:10 AM

Edit: *remider to self: Alway refresh before posting*
Someone beat me to it..

unknowngiver · 01-02-2007, 04:09 PM

yup it was the '
thanks

Dan · 01-02-2007, 05:19 PM

That's why being lazy is good. If you didn't put anything around those, it would have worked.

01-01-2007, 10:16 PM	#1 (permalink)
unknowngiver Senior Member Join Date: May 2005 Location: Ontario Canada Posts: 2,928 1,675.13 NP$ (Donate)	Query error Hey i am getting a querry error from this line: PHP Code: $query = "INSERT INTO `mpg` ('id','Manufacturer','Year','Car Name','Miles Per Gallon City', 'Miles Per Gallon Freeway','Year Gas Price') VALUES ('','$manufacturer','$year','$car_name','$mpgc','$mpgf','$year_gas_price')"; mysql_query($query) or die ("Error, insert query failed"); it gives the "Error,insert query failed" error...and i have 2 questions 1. If there is any visible problem in that piece of code 2. How can i make it show the actual error instead of the die command that i gave it..if i remove that die command..it shows nothing.. __________________ B3Z.NET Proxy \|\| B5Y.NET Proxy \|\| B7J.NET Proxy \|\| B5J.NET Proxy \|\| B5L.NET Proxy cPanelHosting.com-cPanel Experts For 8 Years Hosting From $4.99 And 2 Months Free

01-01-2007, 10:22 PM	#3 (permalink)
unknowngiver Senior Member Join Date: May 2005 Location: Ontario Canada Posts: 2,928 1,675.13 NP$ (Donate)	hm it is like that..i duno y it added that space when i copy pasted it here :-s $query = "INSERT INTO mpg ('id','Manufacturer','Year','Car Name','Miles Per Gallon City', 'Miles Per Gallon Freeway','Year Gas Price') VALUES ('','$manufacturer','$year','$car_name','$mpgc','$ mpgf','$year_gas_price')"; mysql_query($query) or die ("Error, insert query failed"); __________________ B3Z.NET Proxy \|\| B5Y.NET Proxy \|\| B7J.NET Proxy \|\| B5J.NET Proxy \|\| B5L.NET Proxy cPanelHosting.com-cPanel Experts For 8 Years Hosting From $4.99 And 2 Months Free

01-01-2007, 10:33 PM	#5 (permalink)
unknowngiver Senior Member Join Date: May 2005 Location: Ontario Canada Posts: 2,928 1,675.13 NP$ (Donate)	isnt it the samething or did u change something from it? __________________ B3Z.NET Proxy \|\| B5Y.NET Proxy \|\| B7J.NET Proxy \|\| B5J.NET Proxy \|\| B5L.NET Proxy cPanelHosting.com-cPanel Experts For 8 Years Hosting From $4.99 And 2 Months Free

01-02-2007, 04:01 AM	#7 (permalink)
Matthew. Stud Sausage Join Date: Dec 2006 Location: England Posts: 1,546 34.41 NP$ (Donate)	Always added error reporting to every query, this will gve you a more descriptive error as Dan said phpmyadmin will. Run this: PHP Code: $query = "INSERT INTO `mpg` ('id','Manufacturer','Year','Car Name','Miles Per Gallon City', 'Miles Per Gallon Freeway','Year Gas Price') VALUES ('','$manufacturer','$year','$car_name','$mpgc','$ mpgf','$year_gas_price')"; mysql_query($query) or die ("Error, insert query failed" . mysql_error()); Note the mysql_error() has been added. The problem is (i suspect) that you are not using backticks for field names, instead you are using '. Correct query should be: Code: INSERT INTO `mpg` (`id`,`Manufacturer`,`Year`,`Car Name`,`Miles Per Gallon City`, `Miles Per Gallon Freeway`,`Year Gas Price`) VALUES ('','$manufacturer','$year','$car_name','$mpgc','$ mpgf','$year_gas_price') Last edited by Matthew.; 01-02-2007 at 04:15 AM.

01-02-2007, 04:10 AM	#10 (permalink)
Redleg Ultima Ratio Regum Join Date: Sep 2003 Location: Up North Posts: 2,083 71.00 NP$ (Donate)	Edit: remider to self: Alway refresh before posting Someone beat me to it.. __________________ \|Internet, Games, Computer Talk\|IP Whois + Geolocation\|Geolocate your IP\| \|Dynamic Forum Sigs\|2,900+ Free Flash Games\| <meta name="Jedi Mind Trick" content="Buy my domains, you will!"> VoIPUSA.com-MyBlogging.com-ArrivingSoon.com-Nano.tv- Technology.ws-Ammo.us-Racing.cc-Privacy.ws

01-01-2007, 10:20 PM	#2 (permalink)
AzN SI: ServiceInteract Join Date: May 2006 Location: ServiceInteract Posts: 2,551 0.96 NP$ (Donate)	'$ mpgf' should be '$mpgf

01-01-2007, 10:31 PM	#4 (permalink)
AzN SI: ServiceInteract Join Date: May 2006 Location: ServiceInteract Posts: 2,551 0.96 NP$ (Donate)	mysql_query("INSERT INTO mpg ('id','Manufacturer','Year','Car Name','Miles Per Gallon City', 'Miles Per Gallon Freeway','Year Gas Price') VALUES ('','$manufacturer','$year','$car_name','$mpgc','$ mpgf','$year_gas_price'")or die ("Error, insert query failed");

01-01-2007, 10:45 PM	#6 (permalink)
Dan Buy my domains. Join Date: Feb 2006 Posts: 2,801 56.00 NP$ (Donate)	It's the same thing.. >__> Run the query in phpMyAdmin and post the error it gives you. I don't see anything that would just be wrong on its own, unless you can't have spaces in the column titles. The only other thing I see is ' around column names.. shouldn't it be ` or nothing? If you used spaces between items, it wouldn't put that space in by itself into $mpgf

01-02-2007, 04:09 PM	#11 (permalink)
unknowngiver Senior Member Join Date: May 2005 Location: Ontario Canada Posts: 2,928 1,675.13 NP$ (Donate)	yup it was the ' thanks __________________ B3Z.NET Proxy \|\| B5Y.NET Proxy \|\| B7J.NET Proxy \|\| B5J.NET Proxy \|\| B5L.NET Proxy cPanelHosting.com-cPanel Experts For 8 Years Hosting From $4.99 And 2 Months Free

01-02-2007, 05:19 PM	#12 (permalink)
Dan Buy my domains. Join Date: Feb 2006 Posts: 2,801 56.00 NP$ (Donate)	That's why being lazy is good. If you didn't put anything around those, it would have worked.

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)