Script not working

Xyzer · 05-13-2006, 12:46 AM

I am making myself a tutorial management script for a tutorial site like good-tutorials. im sure everything works except the accept script, so if you know whats wrong please say, i will donate you some rep.

Thanks

Steven

Code:

PHP Code:

  
<?php

 
error_reporting(E_ALL ^ E_NOTICE);

 
?>

 
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">

 
<html>

 
<head>

 
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">

 
<title>Untitled Document</title>

 
</head>

 
 
 
<body>

 
<?php

 
mysql_connect("localhost", "root", "");

 
mysql_select_db("tutorials");

 
$query = "SELECT url, id FROM tutorials WHERE status = 'no'";

 
$result = @mysql_query($query);

 
$num = mysql_num_rows ($result);

 
 
 
if ($num > 0) {

 
echo '<table>';

 
while ($row = mysql_fetch_array($result)) {

 
$id = $row[1];

 
echo "<tr>

 
<td></td>

????: NamePros.com http://www.namepros.com/programming/196824-script-not-working.html
 
<td>$row[1]</td><form action=edit.php method=post>

 
<td><input type=hidden value=$row[1] name=ID> </td>

 
<td><select name=action><option value=Delete>Delete<option value=Approve>Approve</select><input type=submit value=Submit name=submit></td></form>

 
</tr>";

 
}

 
 
 
echo '</table>'; 

 
} else {

 
????: NamePros.com http://www.namepros.com/showthread.php?t=196824
echo "The query didnt find any results.";

 
}

 
if ($_POST['ID'] && $_POST['submit'] && $_POST['action']) {

 
$id2 = $_POST['ID'];

 
if ($_POST['action'] == Delete) {

 
$query2 = "DELETE FROM tutorials WHERE id='".$id2."' LIMIT 1"; 

 
$result2 = @mysql_query($query2);

 
} else {

 
$query3 = "UPDATE tutorials SET status='yes' WHERE id='".$id2."' LIMIT 1"; 

 
$result3 = @mysql_query($query3);

 
}

 
 
 
}

 
?>

 
</body>

 
</html>

Eric · 05-13-2006, 01:35 AM

What is your problem exactly? What isn't working? Anyway..i've corrected a couple things that _could_ cause it to not work:

PHP Code:

  <?php

 
error_reporting(E_ALL ^ E_NOTICE);

 
?>

 
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"

    "http://www.w3.org/TR/html4/loose.dtd">

<html>

<head>

<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">

<title>Untitled Document</title>

</head>

 
<body>

 
<?php

 
$db = mysql_connect("localhost", "root", "");

mysql_select_db("tutorials", $db);

 
$query = "SELECT url, id FROM tutorials WHERE status = 'no'";

 
$result = @mysql_query($query);

 
$num = mysql_num_rows($result);

 
if($num > 0)

{

  echo '<table>';

 
  while($row = mysql_fetch_array($result))

  {

    $id = $row[1];

    echo "<tr>

    <td></td>

    <td>$row[1]</td>

    <form action=edit.php method=post>

    <td><input type=hidden value=$row[1] name=ID> </td>

    <td>

    <select name=action>

      <option value=Delete>Delete</option>

      <option value=Approve>Approve</option>

    </select>

    <input type=submit value=Submit name=submit></td>

    </form>

    </tr>";

  }

  echo '</table>';

}

else

{

  echo "The query didnt find any results.";

}

 
if(isset($_POST['submit']) && $_POST['submit'] != '')

????: NamePros.com http://www.namepros.com/showthread.php?t=196824
????: NamePros.com http://www.namepros.com/showthread.php?t=196824
{

  //never trust user input ;)

  //even setting values yourself, select, etc..it can be injected

  $action = trim(strip_tags($_POST['action']));

  $id2 = intval($_POST['ID']);

  

  if(!empty($id) && !empty($action))

  {

    if($action == 'Delete')

    {

      $query2 = "DELETE FROM tutorials WHERE id='".$id2."' LIMIT 1";

      $result2 = @mysql_query($query2);

    }

    else

    {

      $query3 = "UPDATE tutorials SET status='yes' WHERE id='".$id2."' LIMIT 1";

      $result3 = @mysql_query($query3);

    }

  }

  else

  {

    //hmm, that shouldn't happen

  }

}

?>

 
</body>

</html>

Xyzer · 05-13-2006, 01:44 AM

Thanks, i only have one other problem, how can i make it so after i click submit and it does it, it refreshes the page so that that option will go becuase it does when i manually refresh.

ok, another problem is that when i click delete or approve and refresh it comes up again with a different id and its only in the database once. Please help for NP£

NonProphet · 05-13-2006, 10:57 AM

Code:

echo '<meta http-equiv="Refresh" content="0; url=WEBSITE.php">';

Put that at the bottom of each if statement and it will automatically refresh for you

Xyzer · 05-13-2006, 11:00 AM

Thanks, does anyone know how to solve the other bit with it coming up again?

NonProphet · 05-13-2006, 11:01 AM

If it automatically refreshes it should get rid of that problem...

Xyzer · 05-13-2006, 11:03 AM

oh ok, ill try it and get back to you.

right now the only problem is if theres several waiting to be moderated i accept one, it refreshes and the rest disapear until i refresh a few time, What can be causing this?

Dan · 05-13-2006, 03:39 PM

<META HTTP-EQUIV="CACHE-CONTROL" CONTENT="NO-CACHE">

Add that.. I think it'll work. :X

Xyzer · 05-13-2006, 03:41 PM

where do i put that?

Dan · 05-13-2006, 03:53 PM

Anywhere inbetween <head> and </head>

Xyzer · 05-13-2006, 04:01 PM

Thanks dan, all works now.

05-13-2006, 12:46 AM	THREAD STARTER #1 (permalink)
Xyzer Senior Member Join Date: Aug 2005 Location: United Kindom Posts: 1,502	Script not working I am making myself a tutorial management script for a tutorial site like good-tutorials. im sure everything works except the accept script, so if you know whats wrong please say, i will donate you some rep. Thanks Steven Code: PHP Code: <?php error_reporting(E_ALL ^ E_NOTICE); ?> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd"> <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <title>Untitled Document</title> </head> <body> <?php mysql_connect("localhost", "root", ""); mysql_select_db("tutorials"); $query = "SELECT url, id FROM tutorials WHERE status = 'no'"; $result = @mysql_query($query); $num = mysql_num_rows ($result); if ($num > 0) { echo '<table>'; while ($row = mysql_fetch_array($result)) { $id = $row[1]; echo "<tr> <td></td> ????: NamePros.com http://www.namepros.com/programming/196824-script-not-working.html <td>$row[1]</td><form action=edit.php method=post> <td><input type=hidden value=$row[1] name=ID> </td> <td><select name=action><option value=Delete>Delete<option value=Approve>Approve</select><input type=submit value=Submit name=submit></td></form> </tr>"; } echo '</table>'; } else { ????: NamePros.com http://www.namepros.com/showthread.php?t=196824 echo "The query didnt find any results."; } if ($_POST['ID'] && $_POST['submit'] && $_POST['action']) { $id2 = $_POST['ID']; if ($_POST['action'] == Delete) { $query2 = "DELETE FROM tutorials WHERE id='".$id2."' LIMIT 1"; $result2 = @mysql_query($query2); } else { $query3 = "UPDATE tutorials SET status='yes' WHERE id='".$id2."' LIMIT 1"; $result3 = @mysql_query($query3); } } ?> </body> </html>

05-13-2006, 01:35 AM	#2 (permalink)
Eric Senior Member Join Date: Mar 2005 Posts: 4,948	What is your problem exactly? What isn't working? Anyway..i've corrected a couple things that _could_ cause it to not work: PHP Code: <?php error_reporting(E_ALL ^ E_NOTICE); ?> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd"> <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <title>Untitled Document</title> </head> <body> <?php $db = mysql_connect("localhost", "root", ""); mysql_select_db("tutorials", $db); $query = "SELECT url, id FROM tutorials WHERE status = 'no'"; $result = @mysql_query($query); $num = mysql_num_rows($result); if($num > 0) { echo '<table>'; while($row = mysql_fetch_array($result)) { $id = $row[1]; echo "<tr> <td></td> <td>$row[1]</td> <form action=edit.php method=post> <td><input type=hidden value=$row[1] name=ID> </td> <td> <select name=action> <option value=Delete>Delete</option> <option value=Approve>Approve</option> </select> <input type=submit value=Submit name=submit></td> </form> </tr>"; } echo '</table>'; } else { echo "The query didnt find any results."; } if(isset($_POST['submit']) && $_POST['submit'] != '') ????: NamePros.com http://www.namepros.com/showthread.php?t=196824 ????: NamePros.com http://www.namepros.com/showthread.php?t=196824 { //never trust user input ;) //even setting values yourself, select, etc..it can be injected $action = trim(strip_tags($_POST['action'])); $id2 = intval($_POST['ID']); if(!empty($id) && !empty($action)) { if($action == 'Delete') { $query2 = "DELETE FROM tutorials WHERE id='".$id2."' LIMIT 1"; $result2 = @mysql_query($query2); } else { $query3 = "UPDATE tutorials SET status='yes' WHERE id='".$id2."' LIMIT 1"; $result3 = @mysql_query($query3); } } else { //hmm, that shouldn't happen } } ?> </body> </html>

05-13-2006, 01:44 AM	THREAD STARTER #3 (permalink)
Xyzer Senior Member Join Date: Aug 2005 Location: United Kindom Posts: 1,502	Thanks, i only have one other problem, how can i make it so after i click submit and it does it, it refreshes the page so that that option will go becuase it does when i manually refresh. ok, another problem is that when i click delete or approve and refresh it comes up again with a different id and its only in the database once. Please help for NP£

05-13-2006, 10:57 AM	#4 (permalink)
NonProphet NamePros Member Join Date: Apr 2006 Location: Central PA Posts: 101	Code: echo '<meta http-equiv="Refresh" content="0; url=WEBSITE.php">'; Put that at the bottom of each if statement and it will automatically refresh for you

05-13-2006, 11:00 AM	THREAD STARTER #5 (permalink)
Xyzer Senior Member Join Date: Aug 2005 Location: United Kindom Posts: 1,502	Thanks, does anyone know how to solve the other bit with it coming up again?

05-13-2006, 11:01 AM	#6 (permalink)
NonProphet NamePros Member Join Date: Apr 2006 Location: Central PA Posts: 101	If it automatically refreshes it should get rid of that problem...

05-13-2006, 11:03 AM	THREAD STARTER #7 (permalink)
Xyzer Senior Member Join Date: Aug 2005 Location: United Kindom Posts: 1,502	oh ok, ill try it and get back to you. right now the only problem is if theres several waiting to be moderated i accept one, it refreshes and the rest disapear until i refresh a few time, What can be causing this?

05-13-2006, 03:39 PM	#8 (permalink)
Dan Buy my domains. Join Date: Feb 2006 Posts: 2,796	<META HTTP-EQUIV="CACHE-CONTROL" CONTENT="NO-CACHE"> Add that.. I think it'll work. :X

05-13-2006, 03:41 PM	THREAD STARTER #9 (permalink)
Xyzer Senior Member Join Date: Aug 2005 Location: United Kindom Posts: 1,502	where do i put that?

05-13-2006, 03:53 PM	#10 (permalink)
Dan Buy my domains. Join Date: Feb 2006 Posts: 2,796	Anywhere inbetween <head> and </head>

05-13-2006, 04:01 PM	THREAD STARTER #11 (permalink)
Xyzer Senior Member Join Date: Aug 2005 Location: United Kindom Posts: 1,502	Thanks dan, all works now.

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)